unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* Threaded responses to queries (x86)
@ 2023-05-25 18:56 Alison Schofield
  2023-05-31  7:50 ` Eric Wong
  0 siblings, 1 reply; 3+ messages in thread
From: Alison Schofield @ 2023-05-25 18:56 UTC (permalink / raw)
  To: meta; +Cc: Dave Hansen

Hi,

I use Lore and find the threaded results of many Lore Lists useful.
Then there is x86. It doesn't have a list, so I query:

https://lore.kernel.org/all/?q=tc:x86@kernel.org

The result of that query is not threaded. Can I change my query to
get the threading, or, as Dave Hansen suggested below, does the
underlying code need to change.  

Dave's diff follows. I don't have a means of trying that out.

I appreciate help in improving the view of x86!

Thanks,
Alison


diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index a8f1ad17..6d4c148d 100644
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -266,7 +266,8 @@ sub get_new {
 sub get_index {
	my ($ctx) = @_;
 	require PublicInbox::Feed;
-	if ($ctx->{env}->{QUERY_STRING} =~ /(?:\A|[&;])q=/) {
+	if (($ctx->{env}->{QUERY_STRING} =~ /(?:\A|[&;])q=/) &&
+	    ($ctx->{env}->{QUERY_STRING} !~ /(?:\A|[&;])dothread=1/)) {
 		require PublicInbox::SearchView;
 		PublicInbox::SearchView::sres_top_html($ctx);
 	} else {

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: Threaded responses to queries (x86)
  2023-05-25 18:56 Threaded responses to queries (x86) Alison Schofield
@ 2023-05-31  7:50 ` Eric Wong
  2023-05-31 12:05   ` Konstantin Ryabitsev
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Wong @ 2023-05-31  7:50 UTC (permalink / raw)
  To: Alison Schofield; +Cc: meta, Dave Hansen

Alison Schofield <alison.schofield@intel.com> wrote:
> Hi,
> 
> I use Lore and find the threaded results of many Lore Lists useful.
> Then there is x86. It doesn't have a list, so I query:
> 
> https://lore.kernel.org/all/?q=tc:x86@kernel.org
> 
> The result of that query is not threaded. Can I change my query to
> get the threading, or, as Dave Hansen suggested below, does the
> underlying code need to change.  

You can use the `&x=t' parameter to give something similar to
the /$MSGID/T/ URLs which is the "flat" thread output:

	https://lore.kernel.org/all/?q=tc:x86@kernel.org&x=t

The `#t' anchor brings you directly to the thread skeleton overview:

	https://lore.kernel.org/all/?q=tc:x86@kernel.org&x=t#t

There's also an undocumented t=1 parameter which collapses
threads(*) and might reduce clutter from busy threads:

	https://lore.kernel.org/all/?q=tc:x86@kernel.org&x=t&t=1#t

(*) t=1 was only intended for the mbox downloads, but ends up
    affecting HTML output

> Dave's diff follows. I don't have a means of trying that out.

Having a dothread= parameter seems redundant with x=t; but
I agree x=t can display too much and the default summary
view not enough...

> I appreciate help in improving the view of x86!

It's tricky to get the because search results can be ordered by
either relevance or date.  And also the relevance percentage
next to each message.

I wonder if lore can expose x86@kernel.org as its own inbox even
if it's technically not a subscribable mailing list.  That would
be much faster (but less space-efficient) than issuing a Xapian
query to get x86@kernel.org mails.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Threaded responses to queries (x86)
  2023-05-31  7:50 ` Eric Wong
@ 2023-05-31 12:05   ` Konstantin Ryabitsev
  0 siblings, 0 replies; 3+ messages in thread
From: Konstantin Ryabitsev @ 2023-05-31 12:05 UTC (permalink / raw)
  To: Eric Wong; +Cc: Alison Schofield, meta, Dave Hansen

On Wed, May 31, 2023 at 07:50:53AM +0000, Eric Wong wrote:
> I wonder if lore can expose x86@kernel.org as its own inbox even
> if it's technically not a subscribable mailing list.  That would
> be much faster (but less space-efficient) than issuing a Xapian
> query to get x86@kernel.org mails.

I'm not even sure why it's not a real list. Let me follow up with them to see
if we should just convert it.

-K

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-05-31 12:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-25 18:56 Threaded responses to queries (x86) Alison Schofield
2023-05-31  7:50 ` Eric Wong
2023-05-31 12:05   ` Konstantin Ryabitsev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).