From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/6] cindex: drop unneeded module use
Date: Tue, 25 Apr 2023 11:02:53 +0000 [thread overview]
Message-ID: <20230425110258.2538658-2-e@80x24.org> (raw)
In-Reply-To: <20230425110258.2538658-1-e@80x24.org>
I initially thought I'd use the PublicInbox::Eml module and rely
on --pretty=mboxrd; but eventually decided against it since
it wasn't saving any code.
---
lib/PublicInbox/CodeSearchIdx.pm | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/PublicInbox/CodeSearchIdx.pm b/lib/PublicInbox/CodeSearchIdx.pm
index 440c537e..428a40fe 100644
--- a/lib/PublicInbox/CodeSearchIdx.pm
+++ b/lib/PublicInbox/CodeSearchIdx.pm
@@ -16,11 +16,9 @@ package PublicInbox::CodeSearchIdx;
use v5.12;
# parent order matters, we want ->DESTROY from IPC, not SearchIdx
use parent qw(PublicInbox::CodeSearch PublicInbox::IPC PublicInbox::SearchIdx);
-use PublicInbox::Eml;
use PublicInbox::DS qw(awaitpid);
use PublicInbox::PktOp;
use PublicInbox::IPC qw(nproc_shards);
-use PublicInbox::Admin;
use POSIX qw(WNOHANG SEEK_SET);
use File::Path ();
use File::Spec ();
next prev parent reply other threads:[~2023-04-25 11:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 11:02 [PATCH 0/6] cleanups and error message consistency Eric Wong
2023-04-25 11:02 ` Eric Wong [this message]
2023-04-25 11:02 ` [PATCH 2/6] cindex: simplify tmpfile management for indexing Eric Wong
2023-04-25 11:02 ` [PATCH 3/6] cindex: simplify store_repo Eric Wong
2023-04-25 11:02 ` [PATCH 4/6] searchidxshard: use BUG error messages more consistently Eric Wong
2023-04-25 11:02 ` [PATCH 5/6] searchidx: reduce short-lived variables for TermGenerator Eric Wong
2023-04-25 11:02 ` [PATCH 6/6] emergency: make error messages more consistent Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425110258.2538658-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).