From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/4] mid+contenthash: eliminate needless local variable captures
Date: Tue, 25 Apr 2023 10:50:49 +0000 [thread overview]
Message-ID: <20230425105052.3921780-2-e@80x24.org> (raw)
In-Reply-To: <20230425105052.3921780-1-e@80x24.org>
It's possible in theory that Perl could be smarter and free
memory a tad sooner this way. Regardless, fewer lines of code
is easier-to-navigate/read and can save optree size and reduce
parsing times.
---
lib/PublicInbox/ContentHash.pm | 6 ++----
lib/PublicInbox/MID.pm | 6 ++----
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/lib/PublicInbox/ContentHash.pm b/lib/PublicInbox/ContentHash.pm
index d3ff146a..a4f6196f 100644
--- a/lib/PublicInbox/ContentHash.pm
+++ b/lib/PublicInbox/ContentHash.pm
@@ -76,8 +76,7 @@ sub content_digest ($;$) {
last;
}
foreach my $h (qw(Subject Date)) {
- my @v = $eml->header($h);
- foreach my $v (@v) {
+ for my $v ($eml->header($h)) {
utf8::encode($v);
$dig->add("$h\0$v\0");
}
@@ -86,8 +85,7 @@ sub content_digest ($;$) {
# not in the original message. For the purposes of deduplication,
# do not take it into account:
foreach my $h (qw(To Cc)) {
- my @v = $eml->header($h);
- digest_addr($dig, $h, $_) foreach @v;
+ digest_addr($dig, $h, $_) for ($eml->header($h));
}
msg_iter($eml, \&content_dig_i, $dig);
$dig;
diff --git a/lib/PublicInbox/MID.pm b/lib/PublicInbox/MID.pm
index 4819cc25..b1ae9939 100644
--- a/lib/PublicInbox/MID.pm
+++ b/lib/PublicInbox/MID.pm
@@ -92,8 +92,7 @@ sub references ($) {
my ($hdr) = @_;
my @mids;
foreach my $f (qw(References In-Reply-To)) {
- my @v = $hdr->header_raw($f);
- foreach my $v (@v) {
+ for my $v ($hdr->header_raw($f)) {
push(@mids, ($v =~ /$MID_EXTRACT/g));
}
}
@@ -104,8 +103,7 @@ sub references ($) {
my %addr = ( y => 1, n => 1 );
foreach my $f (qw(To From Cc)) {
- my @v = $hdr->header_raw($f);
- foreach my $v (@v) {
+ for my $v ($hdr->header_raw($f)) {
$addr{$_} = 1 for (PublicInbox::Address::emails($v));
}
}
next prev parent reply other threads:[~2023-04-25 10:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 10:50 [PATCH 0/4] mail diff updates Eric Wong
2023-04-25 10:50 ` Eric Wong [this message]
2023-04-25 10:50 ` [PATCH 2/4] mail_diff: match ContentHash EOL and EOM behavior more closely Eric Wong
2023-04-25 10:50 ` [PATCH 3/4] mail_diff: show headers differences in WWW /$MSGID/d/ view Eric Wong
2023-04-25 10:50 ` [PATCH 4/4] content_digest_dbg: improve display of To:/Cc: diffs Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425105052.3921780-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).