unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/4] cindex: always break out of event loop on $DO_QUIT
Date: Tue, 28 Mar 2023 02:59:02 +0000	[thread overview]
Message-ID: <20230328025904.3822761-3-e@80x24.org> (raw)
In-Reply-To: <20230328025904.3822761-1-e@80x24.org>

Shard workers may not die soon enough (or get stuck), just let
the parent die earlier since it doesn't need to commit anything.
---
 lib/PublicInbox/CodeSearchIdx.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/PublicInbox/CodeSearchIdx.pm b/lib/PublicInbox/CodeSearchIdx.pm
index 85e44cdc..6907570d 100644
--- a/lib/PublicInbox/CodeSearchIdx.pm
+++ b/lib/PublicInbox/CodeSearchIdx.pm
@@ -689,6 +689,7 @@ sub do_prune ($) {
 }
 
 sub shards_active { # post_loop_do
+	return if $DO_QUIT;
 	scalar(grep { $_->{-cidx_quit} } @IDX_SHARDS);
 }
 

  parent reply	other threads:[~2023-03-28  2:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28  2:59 [PATCH 0/4] cindex updates Eric Wong
2023-03-28  2:59 ` [PATCH 1/4] cindex: simplify some internal data structures Eric Wong
2023-03-28  2:59 ` Eric Wong [this message]
2023-03-28  2:59 ` [PATCH 3/4] cindex: interleave prune with indexing Eric Wong
2023-03-29 20:32   ` [PATCH v2] " Eric Wong
2023-03-28  2:59 ` [PATCH 4/4] cindex: leave SIGTSTP and SIGCONT unblocked Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230328025904.3822761-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).