From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 66FEB1F41C for ; Sun, 26 Mar 2023 23:48:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1679874483; bh=dVmQ1l7HGFiuMSBFSB+Nzp3bCwwJYNwsqf3VlbXkSDA=; h=From:To:Subject:Date:From; b=nntfSFuZNRm6sLfZkpjDartQCNuHGqzKvAbKqqPoLb5OCJm+xX+TrU5r14Y8nV9r2 ESbocn1qiimDS0/gUWfplpsG7NCtC1Jn/Qud4ZFM6cFSS4cwG7M0dwNinumyONhmuU LyQ5lOBqmNqBATWH11bu0xgbEvgkYKbh1nn7nBzo= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] git: check for --version errors Date: Sun, 26 Mar 2023 23:48:03 +0000 Message-Id: <20230326234803.188447-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: While unlikely, `git --version' may fail, so we must check for errors and by reaping the process ASAP via tied close(). --- lib/PublicInbox/Git.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm index 2729b38f..6f8232cf 100644 --- a/lib/PublicInbox/Git.pm +++ b/lib/PublicInbox/Git.pm @@ -64,6 +64,7 @@ sub check_git_exe () { if ($st ne $EXE_ST) { my $rd = popen_rd([ $GIT_EXE, '--version' ]); my $v = readline($rd); + close($rd) or die "$GIT_EXE --version: $?"; $v =~ /\b([0-9]+(?:\.[0-9]+){2})/ or die "$GIT_EXE --version output: $v # unparseable"; my @v = split(/\./, $1, 3);