From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 46CC61F41C for ; Sun, 26 Mar 2023 08:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1679818892; bh=gTifObhziSMa0srbmmoOXz7wE8IY5Ixn6rqQsfMAe5E=; h=From:To:Subject:Date:From; b=aY7G9WVrzPd0UaNBPGoFCX0pA7c8ZSUJTzZiddaM+atsZ89E8/CfI/NBTJMWvPIRz +6GIj2l02yeyUJChSs71vrpQEEZGGU3C5QEmD/vvgILxPWZrG6U9PjMZV0ahhovEZL FvFdBO/jOxzo7QH/yigD0VWiQbVXZ0d8ZJmIzWeU= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] lei_mirror: fix sh syntax error in "make help" target Date: Sun, 26 Mar 2023 08:21:32 +0000 Message-Id: <20230326082132.1842609-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Oops :x Fixes: 836faf5093df ("lei_mirror: add `index' target to generated Makefile") --- lib/PublicInbox/LeiMirror.pm | 2 +- t/lei-mirror.t | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm index c437b789..e0709fbd 100644 --- a/lib/PublicInbox/LeiMirror.pm +++ b/lib/PublicInbox/LeiMirror.pm @@ -1370,7 +1370,7 @@ help : @echo Rarely needed targets: @echo ' make reindex - may be needed for new features/bugfixes' @echo ' make compact - rewrite Xapian storage to save space' - @echo ' make index - initial index after clone + @echo ' make index - initial index after clone' fetch : public-inbox-fetch diff --git a/t/lei-mirror.t b/t/lei-mirror.t index c172483b..2400578a 100644 --- a/t/lei-mirror.t +++ b/t/lei-mirror.t @@ -1,10 +1,11 @@ #!perl -w -# Copyright (C) 2020-2021 all contributors +# Copyright (C) all contributors # License: AGPL-3.0+ use strict; use v5.10.1; use PublicInbox::TestCommon; use PublicInbox::Inbox; require_mods(qw(-httpd lei DBD::SQLite)); require_cmd('curl'); +use PublicInbox::Spawn qw(which); require PublicInbox::Msgmap; my $sock = tcp_server(); my ($tmpdir, $for_destroy) = tmpdir(); @@ -25,7 +26,10 @@ test_lei({ tmpdir => $tmpdir }, sub { is(PublicInbox::Git::try_cat("$t1/description"), "mirror of $http/t1/\n", 'description set'); ok(-f "$t1/Makefile", 'convenience Makefile added (v1)'); + my $make = which('make'); + xsys_e([$make, 'help'], undef, { -C => $t1, 1 => \(my $help) }); ok(-f "$t1/inbox.config.example", 'inbox.config.example downloaded'); + isnt($help, '', 'make help worked'); is((stat(_))[9], $created{v1}, 'inbox.config.example mtime is ->created_at'); is((stat(_))[2] & 0222, 0, 'inbox.config.example not writable');