From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 48A2D1F4EF for ; Tue, 21 Mar 2023 23:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1679440065; bh=dySV7th2JReVgDdGH/SrUMlqmmXum9Z3khKb6zEbCrA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=HneHcJnsU6ukflNrBY1/Nm1yr9j14OFXZL5anrWlAdKE7CPIdK9yMDxS7ScDCW3Ey mqYM92CU0P3wY3DYw5qETjrFj7h0PkCS2eiPW0eAYwW1R1FBFCk0YP0DMHqusWzWy4 +rnGRnpaKI6FPZIVsIhJbgpgFFNNectl1Bgg3EZY= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 09/28] searchidxshard: improve comment wording Date: Tue, 21 Mar 2023 23:07:24 +0000 Message-Id: <20230321230743.3020032-9-e@80x24.org> In-Reply-To: <20230321230743.3020032-1-e@80x24.org> References: <20230321230701.3019936-1-e@80x24.org> <20230321230743.3020032-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Just something I noticed while considering using this package for CodeSearchIdx. --- lib/PublicInbox/SearchIdxShard.pm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/PublicInbox/SearchIdxShard.pm b/lib/PublicInbox/SearchIdxShard.pm index 000abd94..831be51b 100644 --- a/lib/PublicInbox/SearchIdxShard.pm +++ b/lib/PublicInbox/SearchIdxShard.pm @@ -1,11 +1,10 @@ -# Copyright (C) 2018-2021 all contributors +# Copyright (C) all contributors # License: AGPL-3.0+ # Internal interface for a single Xapian shard in V2 inboxes. # See L for more info on how we shard Xapian package PublicInbox::SearchIdxShard; -use strict; -use v5.10.1; +use v5.12; use parent qw(PublicInbox::SearchIdx PublicInbox::IPC); use PublicInbox::OnDestroy; @@ -47,7 +46,7 @@ sub ipc_atfork_child { # called automatically before ipc_worker_loop $v2w->atfork_child; # calls ipc_sibling_atfork_child on our siblings $v2w->{current_info} = "[$self->{shard}]"; # for $SIG{__WARN__} $self->begin_txn_lazy; - # caller must capture this: + # caller (ipc_worker_spawn) must capture this: PublicInbox::OnDestroy->new($$, \&_worker_done, $self); }