unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] ds: reap_pids: remove redundant signal blocking
@ 2023-03-15 21:47 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2023-03-15 21:47 UTC (permalink / raw)
  To: meta

Blocking signals when reaping was done when the lei pager was
spawned by the daemon in b90e8d6e02.  Shortly afterwards in
7b79c918a5, the client script took over spawning of the pager
and made b90e8d6e02 redundant.

cf. b90e8d6e02 (ds: block signals when reaping, 2021-01-10)
    7b79c918a5 (lei: run pager in client script, 2021-01-10)
---
 lib/PublicInbox/DS.pm | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm
index a08e01f5..b6eaf2d7 100644
--- a/lib/PublicInbox/DS.pm
+++ b/lib/PublicInbox/DS.pm
@@ -214,7 +214,6 @@ sub await_cb ($;@) {
 # that to remain the case.
 sub reap_pids {
 	$reap_armed = undef;
-	my $oldset = block_signals();
 	while (1) {
 		my $pid = waitpid(-1, WNOHANG) // last;
 		last if $pid <= 0;
@@ -224,7 +223,6 @@ sub reap_pids {
 			warn "W: reaped unknown PID=$pid: \$?=$?\n";
 		}
 	}
-	sig_setmask($oldset);
 }
 
 # reentrant SIGCHLD handler (since reap_pids is not reentrant)

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-15 21:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-15 21:47 [PATCH] ds: reap_pids: remove redundant signal blocking Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).