From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/3] use v5.12 for various network client-side packages
Date: Mon, 13 Mar 2023 19:38:25 +0000 [thread overview]
Message-ID: <20230313193827.3635690-2-e@80x24.org> (raw)
In-Reply-To: <20230313193827.3635690-1-e@80x24.org>
None of these are affected by the Perl unicode_strings feature,
so they can `use v5.12' safely
---
lib/PublicInbox/GitCredential.pm | 8 +++++---
lib/PublicInbox/NetNNTPSocks.pm | 5 ++---
lib/PublicInbox/NetReader.pm | 3 +--
lib/PublicInbox/NetWriter.pm | 5 ++---
lib/PublicInbox/URIimap.pm | 5 ++---
lib/PublicInbox/URInntps.pm | 4 ++--
6 files changed, 14 insertions(+), 16 deletions(-)
diff --git a/lib/PublicInbox/GitCredential.pm b/lib/PublicInbox/GitCredential.pm
index b18bba1e..10114a10 100644
--- a/lib/PublicInbox/GitCredential.pm
+++ b/lib/PublicInbox/GitCredential.pm
@@ -1,7 +1,9 @@
-# Copyright (C) 2020-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
+
+# git-credential wrapper with built-in .netrc fallback
package PublicInbox::GitCredential;
-use strict;
+use v5.12;
use PublicInbox::Spawn qw(popen_rd);
sub run ($$;$) {
@@ -19,7 +21,7 @@ sub run ($$;$) {
my $out = '';
for my $k (qw(url protocol host username password)) {
- defined(my $v = $self->{$k}) or next;
+ my $v = $self->{$k} // next;
die "`$k' contains `\\n' or `\\0'\n" if $v =~ /[\n\0]/;
$out .= "$k=$v\n";
}
diff --git a/lib/PublicInbox/NetNNTPSocks.pm b/lib/PublicInbox/NetNNTPSocks.pm
index 8495204a..fcd2e580 100644
--- a/lib/PublicInbox/NetNNTPSocks.pm
+++ b/lib/PublicInbox/NetNNTPSocks.pm
@@ -1,10 +1,9 @@
-# Copyright (C) 2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
# wrap Net::NNTP client with SOCKS support
package PublicInbox::NetNNTPSocks;
-use strict;
-use v5.10.1;
+use v5.12;
use Net::NNTP;
our %OPT;
our @ISA = qw(IO::Socket::Socks);
diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm
index 4de2583e..6802fa72 100644
--- a/lib/PublicInbox/NetReader.pm
+++ b/lib/PublicInbox/NetReader.pm
@@ -3,8 +3,7 @@
# common reader code for IMAP and NNTP (and maybe JMAP)
package PublicInbox::NetReader;
-use strict;
-use v5.10.1;
+use v5.12;
use parent qw(Exporter PublicInbox::IPC);
use PublicInbox::Eml;
use PublicInbox::Config;
diff --git a/lib/PublicInbox/NetWriter.pm b/lib/PublicInbox/NetWriter.pm
index 4a1f34f6..7917ef89 100644
--- a/lib/PublicInbox/NetWriter.pm
+++ b/lib/PublicInbox/NetWriter.pm
@@ -1,10 +1,9 @@
-# Copyright (C) 2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
# common writer code for IMAP (and later, JMAP)
package PublicInbox::NetWriter;
-use strict;
-use v5.10.1;
+use v5.12;
use parent qw(PublicInbox::NetReader);
use PublicInbox::Smsg;
use PublicInbox::MsgTime qw(msg_timestamp);
diff --git a/lib/PublicInbox/URIimap.pm b/lib/PublicInbox/URIimap.pm
index 81644914..41c2842a 100644
--- a/lib/PublicInbox/URIimap.pm
+++ b/lib/PublicInbox/URIimap.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2020-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
# cf. RFC 5092, which the `URI' package doesn't support
#
@@ -11,8 +11,7 @@
#
# RFC 2192 also describes ";TYPE=<list_type>"
package PublicInbox::URIimap;
-use strict;
-use v5.10.1;
+use v5.12;
use URI::Split qw(uri_split uri_join); # part of URI
use URI::Escape qw(uri_unescape uri_escape);
use overload '""' => \&as_string;
diff --git a/lib/PublicInbox/URInntps.pm b/lib/PublicInbox/URInntps.pm
index 231b247b..88c8d641 100644
--- a/lib/PublicInbox/URInntps.pm
+++ b/lib/PublicInbox/URInntps.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
# deal with the lack of URI::nntps in upstream URI.
@@ -6,7 +6,7 @@
# cf. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983419
# Fixed in URI 5.08, we can drop this by 2035 when LTS distros all have it
package PublicInbox::URInntps;
-use strict;
+use v5.12;
use parent qw(URI::snews);
use URI;
next prev parent reply other threads:[~2023-03-13 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 19:38 [PATCH 0/3] watch-related IMAP/NNTP tweaks Eric Wong
2023-03-13 19:38 ` Eric Wong [this message]
2023-03-13 19:38 ` [PATCH 2/3] spamcheck: use v5.12 and golf Eric Wong
2023-03-13 19:38 ` [PATCH 3/3] watch: add space before "UID" or "ARTICLE" in warnings Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313193827.3635690-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).