From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 74E5F1F47D for ; Tue, 7 Mar 2023 09:54:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1678182855; bh=44eDYL5leJlF0DqRiZ/1mH9d8iTcnhf2g9hDD1fDTxg=; h=From:To:Subject:Date:From; b=2Rzz7bkdP1FgVSCSbD00IKm6ewpiX0uXxMs4hjh0zXD8Bvv3wl4TpmTwrP69devQM 8ijfmO7vJCtKihOmMRgrI5+OzuD6KQv6G7cTLpuWJQ77c+BLVMsnu+7ys+LpIn9+e5 OLz/xqyLVPg3eNS/2YQcn/QNFvpiLfBlt6wf5ins= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] test_common: run_script: drop special-case for -clone Date: Tue, 7 Mar 2023 09:54:15 +0000 Message-Id: <20230307095415.403649-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: `make check' and `make check-run' actually work fine with it, and TMPDIR=/dev/shm prove -lvw t/clone-coderepo.t is 2-3x faster --- lib/PublicInbox/TestCommon.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm index 8a34e45a..a550a5a1 100644 --- a/lib/PublicInbox/TestCommon.pm +++ b/lib/PublicInbox/TestCommon.pm @@ -295,7 +295,6 @@ sub run_script ($;$$) { my ($cmd, $env, $opt) = @_; my ($key, @argv) = @$cmd; my $run_mode = $ENV{TEST_RUN_MODE} // $opt->{run_mode} // 1; - $run_mode = 0 if $key eq '-clone'; # relies on SIGCHLD + waitpid(-1) my $sub = $run_mode == 0 ? undef : key2sub($key); my $fhref = []; my $spawn_opt = {};