* [PATCH] test_common: run_script: drop special-case for -clone
@ 2023-03-07 9:54 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2023-03-07 9:54 UTC (permalink / raw)
To: meta
`make check' and `make check-run' actually work fine with it,
and TMPDIR=/dev/shm prove -lvw t/clone-coderepo.t is 2-3x faster
---
lib/PublicInbox/TestCommon.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index 8a34e45a..a550a5a1 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -295,7 +295,6 @@ sub run_script ($;$$) {
my ($cmd, $env, $opt) = @_;
my ($key, @argv) = @$cmd;
my $run_mode = $ENV{TEST_RUN_MODE} // $opt->{run_mode} // 1;
- $run_mode = 0 if $key eq '-clone'; # relies on SIGCHLD + waitpid(-1)
my $sub = $run_mode == 0 ? undef : key2sub($key);
my $fhref = [];
my $spawn_opt = {};
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-07 9:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-07 9:54 [PATCH] test_common: run_script: drop special-case for -clone Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).