From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id AC6001FA2F for ; Sat, 28 Jan 2023 11:03:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1674903804; bh=4FrJxbOTiL1XDjPHhi2qLZiNK4EOtUBDKd8vClCFguM=; h=From:To:Subject:Date:In-Reply-To:References:From; b=XUBCuXNYoVIg7pnHJWiiTYnX09Il5UV0LKcg/iv2TmB/SugYqqASkV5pbxlm0RnJL sTeh+ZYoVgZbDsQj1NEibtEI4rrQC2dSxp0fM7wIqlXb/8kuWCpxIifLf36NuSkAhi s4J++QQJ4sJJELf/95wscJ901ePbd9n+7Qfe41FQ= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 7/7] www_coderepo: summary: fix mis-linkification of `...' Date: Sat, 28 Jan 2023 11:02:55 +0000 Message-Id: <20230128110255.2950084-8-e@80x24.org> In-Reply-To: <20230128110255.2950084-1-e@80x24.org> References: <20230128110255.2950084-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We need to use the ternary operator in assignments to clobber previous values of `$last'. --- lib/PublicInbox/WwwCoderepo.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/WwwCoderepo.pm b/lib/PublicInbox/WwwCoderepo.pm index d28b1a03..7a2cb80b 100644 --- a/lib/PublicInbox/WwwCoderepo.pm +++ b/lib/PublicInbox/WwwCoderepo.pm @@ -129,7 +129,7 @@ sub summary_finish { # git log my @r = split(/\n/s, pop(@x) // ''); - my $last = pop(@r) if scalar(@r) > $ctx->{wcr}->{summary_log}; + my $last = scalar(@r) > $ctx->{wcr}->{summary_log} ? pop(@r) : undef; my $tip_html = ''; if (defined(my $tip = $ctx->{qp}->{h})) { $tip_html .= ' '.ascii_html($tip).' --'; @@ -165,14 +165,14 @@ EOM # refs/heads print $zfh '', $HEADS_CMD , ''; @r = split(/^/sm, shift(@x) // ''); - $last = pop(@r) if scalar(@r) > $ctx->{wcr}->{summary_branches}; + $last = scalar(@r) > $ctx->{wcr}->{summary_branches} ? pop(@r) : undef; chomp(@r); for (@r) { print $zfh _refs_heads_link($_, './') } print $zfh $NO_HEADS if !@r; print $zfh qq(...\n) if $last; print $zfh "\n", $TAGS_CMD, ''; @r = split(/^/sm, shift(@x) // ''); - $last = pop(@r) if scalar(@r) > $ctx->{wcr}->{summary_tags}; + $last = scalar(@r) > $ctx->{wcr}->{summary_tags} ? pop(@r) : undef; my ($snap_pfx, @snap_fmt) = _snapshot_link_prep($ctx); chomp @r; for (@r) { print $zfh _refs_tags_link($_, './', $snap_pfx, @snap_fmt) }