From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 7CA6E1FA33 for ; Tue, 24 Jan 2023 09:50:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1674553805; bh=i+JaGjKnlkUi+wKq8JauAlRHuTai/I51mcMYAweutEM=; h=From:To:Subject:Date:In-Reply-To:References:From; b=DagZ9GdyQXZkiH4ayVdJfCwAWKtgoIPiS50cn+cu523qk9OSOmXWM5RgXXOCU1lSs 2gr7mltuZhBcVJOUh8hogno5NZZPBSHxoQSSZ1GT9EIrhgz+KX2hkHzcI+i1niNA05 ce0EyUrAiVHIlKYxAb7KjphDiXWBT4AOp5sgkIMM= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 08/11] viewvcs: show message for 404||500 errors Date: Tue, 24 Jan 2023 09:49:37 +0000 Message-Id: <20230124094940.572017-9-e@80x24.org> In-Reply-To: <20230124094940.572017-1-e@80x24.org> References: <20230124094940.572017-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Since the debug log isn't present from the /$REPO/ URLs, the lack of debug log makes 404s look confusing. --- lib/PublicInbox/ViewVCS.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm index 0dfe6081..99f5e24f 100644 --- a/lib/PublicInbox/ViewVCS.pm +++ b/lib/PublicInbox/ViewVCS.pm @@ -497,8 +497,9 @@ sub show_tag ($$) { sub solve_result { my ($res, $ctx) = @_; my $hints = delete $ctx->{hints}; - $res or return html_page($ctx, 404, dbg_log($ctx)); - ref($res) eq 'ARRAY' or return html_page($ctx, 500, dbg_log($ctx)); + $res or return html_page($ctx, 404, 'Not found', dbg_log($ctx)); + ref($res) eq 'ARRAY' or + return html_page($ctx, 500, 'Internal error', dbg_log($ctx)); my ($git, $oid, $type, $size, $di) = @$res; return show_commit($ctx, $res) if $type eq 'commit';