From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/3] git: pub_urls shows base_url default
Date: Wed, 4 Jan 2023 10:34:04 +0000 [thread overview]
Message-ID: <20230104103405.2432349-3-e@80x24.org> (raw)
In-Reply-To: <20230104103405.2432349-1-e@80x24.org>
Since we have native coderepo viewing support without cgit,
configuring coderepo.$FOO.cgitUrl shouldn't be necessary anymore
and we can infer the public name based on the project nickname
(or whatever's in the generated project.list)
---
lib/PublicInbox/Git.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 68f72052..f6abe185 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -480,9 +480,10 @@ sub isrch {} # TODO
sub pub_urls {
my ($self, $env) = @_;
if (my $urls = $self->{cgit_url}) {
- return map { host_prefix_url($env, $_) } @$urls;
+ map { host_prefix_url($env, $_) } @$urls;
+ } else {
+ (base_url($self, $env));
}
- (local_nick($self) // '???');
}
sub cat_async_begin {
next prev parent reply other threads:[~2023-01-04 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 10:34 [PATCH 0/3] www: cleanup URL generation around coderepos Eric Wong
2023-01-04 10:34 ` [PATCH 1/3] git: fix non-empty SCRIPT_NAME handling for PSGI mounts Eric Wong
2023-01-04 10:34 ` Eric Wong [this message]
2023-01-05 9:58 ` [PATCH 2/3] git: pub_urls shows base_url default Eric Wong
2023-01-04 10:34 ` [PATCH 3/3] www: make coderepo URL generation more consistent Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104103405.2432349-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).