From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 936431F6A3 for ; Fri, 30 Dec 2022 10:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1672397980; bh=h83rKCpqCwpch4WHcPWYDTt3lMymEZD0vbqf3Yp61GU=; h=From:To:Subject:Date:In-Reply-To:References:From; b=s2aNBrlpVQljEwQpseFRgw2YhBC4U999AoN5VNOqJ3lrGha4v52+L+osJml8YZpQn yysmvmCVJEfX8H4GXoDl7I4fBXPYQ9AFwyxHlH6tvTHBB7HjorTPtoCQm6OBc/GEbR 1ddcGm99awXPQYH6lJsJ9ZzutCzQqEC+Hg/XiXrU= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 1/2] clone: --dry-run unconditionally runs show-ref Date: Fri, 30 Dec 2022 10:59:38 +0000 Message-Id: <20221230105939.4119509-2-e@80x24.org> In-Reply-To: <20221230105939.4119509-1-e@80x24.org> References: <20221230105939.4119509-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: It's useful to show what's being updated, of course. --- lib/PublicInbox/LeiMirror.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm index 5952ed52..bfbfd843 100644 --- a/lib/PublicInbox/LeiMirror.pm +++ b/lib/PublicInbox/LeiMirror.pm @@ -493,7 +493,6 @@ sub cmp_fp_do { $self->{-show_ref} = $opt->{1}; do_reap($self); $self->{lei}->qerr("# @$cmd"); - return if $self->{dry_run}; $LIVE->{spawn($cmd, undef, $opt)} = [ \&fp_done, $self, $cmd, $cb, @arg ]; }