From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 06CC41FA00 for ; Fri, 23 Dec 2022 11:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1671793516; bh=jU+ceU4HC/f74HLpsUag/4Z6u82PdkF+TyeFynB3uzw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=0x3mmzPRXl4Agog3VEkCcvvOLMt0SD3HpwutROfJu6yBWsyIEBJ+rbbod8FT7e/TQ YV8UX/0019RLztXbKoqG0k7o6hlry9+2fS91nHVg+X/fHcR3XrV02tIkDDEmKxSdno fb3AyI59UkK8pMgl0iAGV8UlcHxs0KvVHwJDcbYc= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 3/4] qspawn: shorten life of {hdr_buf} in generic code path Date: Fri, 23 Dec 2022 11:05:14 +0000 Message-Id: <20221223110515.19907-4-e@80x24.org> In-Reply-To: <20221223110515.19907-1-e@80x24.org> References: <20221223110515.19907-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: No point in keeping the old buffer around if we don't need to. --- lib/PublicInbox/Qspawn.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm index ef9db43e..da7cd74f 100644 --- a/lib/PublicInbox/Qspawn.pm +++ b/lib/PublicInbox/Qspawn.pm @@ -247,9 +247,9 @@ sub psgi_return_init_cb { delete($self->{hdr_buf})); } else { # for synchronous PSGI servers require PublicInbox::GetlineBody; + my $buf = delete $self->{hdr_buf}; $r->[2] = PublicInbox::GetlineBody->new($self->{rpipe}, - \&event_step, $self, - ${$self->{hdr_buf}}, $filter); + \&event_step, $self, $$buf, $filter); $wcb->($r); } }