From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 250D51F93C for ; Wed, 23 Nov 2022 04:09:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1669176599; bh=OwN0jTPyKpB8oA681ORA0C6u9RBmvzkYkIF4LTy/xHw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=JmykqrKxyGQi31rMtJMUqlUe5jNxV8pXUoTBUuPSNrF2ahZhpIUGUXlh/3XJK+9dP PfFA8ZYZLVMXOdQfZlkHb3qYvlRevmrF/8h6S5b/O1ZuA88fN8+zhkjvB5Cy6FtXtJ 5jONjvdUo44wW/crIoi1yLstr6lkQMiZbX2xQCv8= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 1/3] lei_curl: set --proxy for curl(1) properly Date: Wed, 23 Nov 2022 04:09:56 +0000 Message-Id: <20221123040958.114960-2-e@80x24.org> In-Reply-To: <20221123040958.114960-1-e@80x24.org> References: <20221123040958.114960-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: curl(1) doesn't accept `--proxy=' with the `=', apparently :x --- lib/PublicInbox/LeiCurl.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/LeiCurl.pm b/lib/PublicInbox/LeiCurl.pm index 4e602a48..f5e95956 100644 --- a/lib/PublicInbox/LeiCurl.pm +++ b/lib/PublicInbox/LeiCurl.pm @@ -7,8 +7,7 @@ # n.b. curl may support a daemon/client model like lei someday: # https://github.com/curl/curl/wiki/curl-tool-master-client package PublicInbox::LeiCurl; -use strict; -use v5.10.1; +use v5.12; use PublicInbox::Spawn qw(which); use PublicInbox::Config; @@ -78,7 +77,7 @@ sub for_uri { if ($uri->scheme =~ /\Ahttps?\z/i) { my $cfg = $lei->_lei_cfg; my $p = $cfg ? $cfg->urlmatch('http.Proxy', $$uri) : undef; - push(@opt, "--proxy=$p") if defined($p); + push(@opt, '--proxy', $p) if defined($p); } bless [ @$pfx, @$self, @opt, $uri->as_string ], ref($self); }