unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 5/6] lei_mirror: make _finish_add_external call more obvious
Date: Thu, 20 Oct 2022 08:43:13 +0000	[thread overview]
Message-ID: <20221020084314.1668067-6-e@80x24.org> (raw)
In-Reply-To: <20221020084314.1668067-1-e@80x24.org>

I get easily confused, sometimes :x
---
 lib/PublicInbox/LeiMirror.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm
index fa1d2e88..1dbd4d0a 100644
--- a/lib/PublicInbox/LeiMirror.pm
+++ b/lib/PublicInbox/LeiMirror.pm
@@ -25,6 +25,7 @@ sub _wq_done_wait { # dwaitpid callback (via wq_eof)
 		warn("unlink($f): $!\n") unless $!{ENOENT};
 	} else {
 		if ($lei->{cmd} ne 'public-inbox-clone') {
+			# calls _finish_add_external
 			$lei->lazy_cb('add-external', '_finish_'
 					)->($lei, $mrr->{dst});
 		}

  parent reply	other threads:[~2022-10-20  8:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20  8:43 [PATCH 0/6] trivial clone|fetch-related stuff Eric Wong
2022-10-20  8:43 ` [PATCH 1/6] clone|fetch: preserve mtime of modified manifest.js.gz Eric Wong
2022-10-20  8:43 ` [PATCH 2/6] another step towards git SHA-256 support Eric Wong
2022-10-20  8:43 ` [PATCH 3/6] githttpbackend: remove unused $BIN variable Eric Wong
2022-10-20  8:43 ` [PATCH 4/6] treewide: replace /^I: / prefix with /^# / Eric Wong
2022-10-20  8:43 ` Eric Wong [this message]
2022-10-20  8:43 ` [PATCH 6/6] lei_mirror: delimit names by `\n' to improve die message Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221020084314.1668067-6-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).