From: Eric Wong <e@80x24.org>
To: "Nicolás Ojeda Bär" <n.oje.bar@gmail.com>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] SIGWINCH is 28 on Darwin-based OSes
Date: Mon, 17 Oct 2022 08:33:10 +0000 [thread overview]
Message-ID: <20221017083310.M627912@dcvr> (raw)
In-Reply-To: <20221015081246.18167-2-n.oje.bar@gmail.com>
Thanks. Pushed as commit 70d2806f623b7d5c8fe8328f8e53a24e7be34393
with slightly edited commit message and comments to avoid
mention of a non-Free platform:
From: =?UTF-8?q?Nicol=C3=A1s=20Ojeda=20B=C3=A4r?= <n.oje.bar@gmail.com>
Date: Sat, 15 Oct 2022 10:12:46 +0200
Subject: [PATCH] SIGWINCH is 28 on Darwin-based OSes
[ew: avoid mention of non-Free platform]
Acked-by: Eric Wong <e@80x24.org>
---
lib/PublicInbox/Sigfd.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Sigfd.pm b/lib/PublicInbox/Sigfd.pm
index 81e5a1b1..583f9f14 100644
--- a/lib/PublicInbox/Sigfd.pm
+++ b/lib/PublicInbox/Sigfd.pm
@@ -15,8 +15,8 @@ sub new {
my ($class, $sig, $nonblock) = @_;
my %signo = map {;
my $cb = $sig->{$_};
- # SIGWINCH is 28 on FreeBSD, NetBSD, OpenBSD
- my $num = ($_ eq 'WINCH' && $^O =~ /linux|bsd/i) ? 28 : do {
+ # SIGWINCH is 28 on FreeBSD, NetBSD, OpenBSD, Darwin
+ my $num = ($_ eq 'WINCH' && $^O =~ /linux|bsd|darwin/i) ? 28 : do {
my $m = "SIG$_";
POSIX->$m;
};
next prev parent reply other threads:[~2022-10-17 8:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 8:12 SIGWINCH not recognized under macOS Nicolás Ojeda Bär
2022-10-15 8:12 ` [PATCH] SIGWINCH is 28 on macOS Nicolás Ojeda Bär
2022-10-17 8:33 ` Eric Wong [this message]
2022-10-17 9:30 ` [PATCH 0/2] fix SIGWINCH for Linux MIPS and PA-RISC Eric Wong
2022-10-17 9:30 ` [PATCH 1/2] syscall: avoid needless string comparison on x86-64 Eric Wong
2022-10-17 9:30 ` [PATCH 2/2] sigfd: set SIGWINCH for MIPS and PA-RISC on Linux Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221017083310.M627912@dcvr \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
--cc=n.oje.bar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).