From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/2] import: pass --quiet to `git gc' if STDERR isn't a tty
Date: Fri, 2 Sep 2022 18:26:23 +0000 [thread overview]
Message-ID: <20220902182624.8276-3-e@80x24.org> (raw)
In-Reply-To: <20220902182624.8276-1-e@80x24.org>
No need to pollute non-interactive output for gc use. This
suppresses notifications from my `lei up --all -q' cronjob.
---
lib/PublicInbox/Import.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index 2c8f310a..04192174 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -192,7 +192,10 @@ sub _update_git_info ($$) {
};
warn "$ibx->{inboxdir} index failed: $@\n" if $@;
}
- eval { run_die([@cmd, qw(gc --auto)]) } if $do_gc;
+ if ($do_gc) {
+ my @quiet = (-t STDERR ? () : '-q');
+ eval { run_die([@cmd, qw(gc --auto), @quiet]) }
+ }
}
sub barrier {
prev parent reply other threads:[~2022-09-02 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 18:26 [PATCH 0/2] lei-related import tweaks Eric Wong
2022-09-02 18:26 ` [PATCH 1/2] lei/store: do not write info/refs file Eric Wong
2022-09-02 18:26 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902182624.8276-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).