From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B9E8E1F620 for ; Mon, 29 Aug 2022 09:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1661765208; bh=BT2V+kh2dKv7QpDjkuxkcBlxlCeCqI9eiv3z4ZrxI/I=; h=From:To:Subject:Date:In-Reply-To:References:From; b=tLbNvxIwrJM5DjeJKC1zjERRc40MDk77jmCe4Fr2RWv2J2as4xDdY1DolGkAOrk4v pQdDI/RAQFefJGDm5XFAouE8TbXUUgcoCWNDaUILnF8Wj+XJ/LwBs7XYJweaCNytjf qdQ3wbwGvj2UlhbWEYFqbQE0k+xxiud8BHcnFDk4= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 08/18] view: speed up /$INBOX/ landing page by 0.5-1.0% Date: Mon, 29 Aug 2022 09:26:37 +0000 Message-Id: <20220829092647.1512215-9-e@80x24.org> In-Reply-To: <20220829092647.1512215-1-e@80x24.org> References: <20220829092647.1512215-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Array lookups and extra arithmetic in Perl is slower than bumping the internal array offset inside the interpreter. Fwiw, using: my ($level, $subj) = splice(@extra, 0, 2) did not result in a performance improvement. --- lib/PublicInbox/View.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 5fbdd1fa..9846fa47 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -1188,9 +1188,9 @@ sub dump_topics { my $s = "$top_subj\n" . " $ds UTC $n\n"; - for (my $i = 0; $i < scalar(@extra); $i += 2) { - my $level = $extra[$i]; - my $subj = $extra[$i + 1]; # already normalized + while (@extra) { + my $level = shift @extra; + my $subj = shift @extra; # already normalized $mid = delete $seen->{$subj}; my @subj = split(/ /, $subj); my @next_prev = @subj; # full copy