From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 6FFF31F619 for ; Tue, 23 Aug 2022 08:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1661243524; bh=zfG+U8Bg7Hl1QmpnPGVMlOc9lhgGdJGB+Kyv8+irjkE=; h=From:To:Subject:Date:In-Reply-To:References:From; b=cseSe6KrxZFqhTcvHvzkvk4TKa4a6asVNZJUWj2/rnXhXqWnhElQRgetKV4lLXpuA kMKPpTqJ99GtWer457lcfwo7ezJIhIJIzbIGHdAwQ9cb9JnbQ+oM6zzZ09MwiogRKy PY1eQzA93M71FDXQsEAE4FQuYwWtEtdiFsrrA+mU= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 3/8] viewvcs: remove patchid line from commit header Date: Tue, 23 Aug 2022 08:31:58 +0000 Message-Id: <20220823083203.1128993-4-e@80x24.org> In-Reply-To: <20220823083203.1128993-1-e@80x24.org> References: <20220823083203.1128993-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: I'm considering dropping this entirely since dfpre:, dfpost: dfn:, and s: can be just as powerful, if not more. patchid: is inaccurate if either non-standard diff generation options are used (e.g. -W or -U6); or if a MUAs mangle whitespace. We'll keep patchid: at the top search input box for now, but the textarea at the bottom (and possibly another textarea for a more exact match) is probably more useful and flexible. --- lib/PublicInbox/ViewVCS.pm | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm index 4165a1de..a73fbf0f 100644 --- a/lib/PublicInbox/ViewVCS.pm +++ b/lib/PublicInbox/ViewVCS.pm @@ -102,12 +102,7 @@ sub show_commit_result ($$) { } my $upfx = $ctx->{-upfx} = '../../'; # from "/$INBOX/$OID/s/" my $patchid = (split(/ /, $$bref))[0]; # ignore commit - if (defined $patchid) { - $ctx->{-q_value_html} = "patchid:$patchid"; - $patchid = "\n patchid $patchid"; - } else { - $patchid = ''; - } + $ctx->{-q_value_html} = "patchid:$patchid" if defined $patchid; my $l = $ctx->{-linkify} = PublicInbox::Linkify->new; open my $fh, '<:utf8', "$tmp/h" or die "open $tmp/h: $!"; chop(my $buf = do { local $/ = "\0"; <$fh> }); @@ -141,7 +136,7 @@ sub show_commit_result ($$) { 
   commit $H$P
      tree $T
    author $au
-committer $co$patchid
+committer $co
 
 $s\n
 EOM