From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
	T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no
	version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id CFDCD1F54E;
	Mon, 22 Aug 2022 04:57:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1661144248;
	bh=cGx7vnhszwmui26xMQTsZzhqTMMrPshKjAkzDmwPZ8A=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=MrboHFjh7SRGYa6rDnDk2JHzuoeNzESF4y4Qi24gIQeVzRydHmfu4J/M3HH/B58oz
	 mooem3c03UAvZJfp8spOhBhV6U2BjgZvIB/IIayrx23d3981TfUbUaPigtcbDz7GR0
	 7Z5aTxh9XL91WvhO/A72KLcxtgngjoyui3PEVALw=
Date: Mon, 22 Aug 2022 04:57:28 +0000
From: Eric Wong <e@80x24.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: =?utf-8?B?UmVuw6k=?= Scharfe <l.s.r@web.de>, git@vger.kernel.org,
	meta@public-inbox.org
Subject: Re: `git patch-id --stable' vs quoted-printable
Message-ID: <20220822045728.GA453@dcvr>
References: <20220822022503.M873583@dcvr>
 <xmqqczcsgbvn.fsf@gitster.g>
 <xmqq7d30gbcd.fsf@gitster.g>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <xmqq7d30gbcd.fsf@gitster.g>
List-Id: <meta.public-inbox.org>

Junio C Hamano <gitster@pobox.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> 
> >> So, I'm wondering if the search indexing code of public-inbox
> >> should s/^$/ /mgs before feeding stuff to `git patch-id'; and/or
> >> if `git patch-id' should be assuming empty lines and lines with a
> >> single SP are the same...
> 
> Another potential source of issues (not for the patch from René that
> was used as an example) is that a patch producer can use different
> diff algorithm from the setting you would use to index resulting
> commits via "git show | git patch-id".
> 
>     $ git show -U5 | git patch-id
>     $ git show | git patch-id
> 
> likely result in different patch IDs.  
> 
> The --patience and the --histogram options affect how common lines
> are matched up, again affecting the shape of the patches you compute
> patch-ids over.

Yes, you're right; though I suppose most users use git defaults.
I'm not sure how useful patchid ends up being, actually...
The old use of dfpre/dfpost blob OIDs seems to have been working
well for years, already.

Possibly OR-ing them with patchid in Xapian will end up getting
good enough search engine coverage.