unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 6/7] viewvcs: drop pointless variable assignment
Date: Mon, 22 Aug 2022 02:33:45 +0000	[thread overview]
Message-ID: <20220822023346.938859-7-e@80x24.org> (raw)
In-Reply-To: <20220822023346.938859-1-e@80x24.org>

Not needed since commit:
41f03a3bd4b13dfa (viewvcs: do not show final error message twice, 2019-01-27)
---
 lib/PublicInbox/ViewVCS.pm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index d3fd152d..94656ad3 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -114,13 +114,12 @@ sub solve_result {
 	}
 	$log = do { local $/; <$log> };
 
-	my $ref = ref($res);
 	my $l = PublicInbox::Linkify->new;
 	$log = '<pre>debug log:</pre><hr /><pre>' .
 		$l->to_html($log) . '</pre>';
 
 	$res or return html_page($ctx, 404, \$log);
-	$ref eq 'ARRAY' or return html_page($ctx, 500, \$log);
+	ref($res) eq 'ARRAY' or return html_page($ctx, 500, \$log);
 
 	my ($git, $oid, $type, $size, $di) = @$res;
 	return show_other($ctx, $res, \$log, $fn) if $type ne 'blob';

  parent reply	other threads:[~2022-08-22  2:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22  2:33 [PATCH 0/7] an even bigger git show than before Eric Wong
2022-08-22  2:33 ` [PATCH 1/7] config: fix confusing space in ->repo_objs Eric Wong
2022-08-22  2:33 ` [PATCH 2/7] xt/solver: improve diagnostics Eric Wong
2022-08-22  2:33 ` [PATCH 3/7] www: /s/: 404 for unconfigured coderepos Eric Wong
2022-08-22  2:33 ` [PATCH 4/7] qspawn: add type comments in a few places Eric Wong
2022-08-22  2:33 ` [PATCH 5/7] qspawn: improve error reporting and handling Eric Wong
2022-08-22  2:33 ` Eric Wong [this message]
2022-08-22  2:33 ` [PATCH 7/7] viewvcs: start improving display of git commits Eric Wong
2022-08-22  6:44 ` [PATCH 8/7] viewvcs: use :utf8 for opening patch, too Eric Wong
2022-08-22 19:34 ` extindex for git? [was: an even bigger git show than before...] Eric Wong
2022-08-25 21:34   ` Eric Wong
2022-08-26 16:51     ` Konstantin Ryabitsev
2022-08-26 18:11       ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220822023346.938859-7-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).