unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: git@vger.kernel.org
Cc: meta@public-inbox.org
Subject: `git patch-id --stable' vs quoted-printable
Date: Mon, 22 Aug 2022 02:25:03 +0000	[thread overview]
Message-ID: <20220822022503.M873583@dcvr> (raw)

While poking around at the newish patchid indexing support in
public-inbox[1], I noticed an inconsistency in how it seems to
mishandle quoted-printable messages.

For instance, René's message can apply fine with `git am':

https://public-inbox.org/git/6727daf1-f077-7319-187e-ab4e55de3b2d@web.de/raw

However, note the blank context lines are truly blank, as in /^$/,
not /^ $/.  Running `git patch-id --stable' on the decoded content
of that message gives me: a245e99dbd2ce6e319955569eb8a111cb044f474
And that's the value public-inbox indexes.

That patch ends up being commit fc0f8bcd64eb0a03a7098f72da9c4008bd48cf11
in git.git.

However,
`git show fc0f8bcd64eb0a03a7098f72da9c4008bd48cf11 |git patch-id --stable'
gives me: fcac4cf581e11b703c229a129072c95c79b68bf

So, I'm wondering if the search indexing code of public-inbox
should s/^$/ /mgs before feeding stuff to `git patch-id'; and/or
if `git patch-id' should be assuming empty lines and lines with a
single SP are the same...


[1] https://public-inbox.org/meta/20220620192730.550803-3-e@80x24.org/

             reply	other threads:[~2022-08-22  2:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22  2:25 Eric Wong [this message]
2022-08-22  4:06 ` `git patch-id --stable' vs quoted-printable Junio C Hamano
2022-08-22  4:18   ` Junio C Hamano
2022-08-22  4:57     ` Eric Wong
2022-08-22 15:58   ` René Scharfe
2022-08-22 16:21     ` Junio C Hamano
2022-08-22 17:01       ` Eric Wong
2022-08-22 18:25         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220822022503.M873583@dcvr \
    --to=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).