* [PATCH] pop3: fix off-by-one error when handling `EXPIRE 0'
@ 2022-08-12 21:30 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2022-08-12 21:30 UTC (permalink / raw)
To: meta
mark_dele already works on the cache offset, so there's no need
to make further adjustments to the offset (as we do with POP3
sequence numbers).
---
lib/PublicInbox/POP3.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/POP3.pm b/lib/PublicInbox/POP3.pm
index 82df257c..63299869 100644
--- a/lib/PublicInbox/POP3.pm
+++ b/lib/PublicInbox/POP3.pm
@@ -233,7 +233,7 @@ sub retr_cb { # called by git->cat_async via ibx_async_cat
my @tmp = split(/^/m, $bdy);
$hdr .= join('', splice(@tmp, 0, $top_nr));
} elsif (exists $self->{expire}) {
- $self->{expire} .= pack('S', $off + 1);
+ $self->{expire} .= pack('S', $off);
}
$$bref =~ s/^\./../gms;
$$bref .= substr($$bref, -2, 2) eq "\r\n" ? ".\r\n" : "\r\n.\r\n";
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-08-12 21:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-12 21:30 [PATCH] pop3: fix off-by-one error when handling `EXPIRE 0' Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).