From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.1 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
	T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no
	version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 0A8A31F54E
	for <meta@public-inbox.org>; Thu, 11 Aug 2022 21:57:38 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1660255058;
	bh=29nuhggppQeTuciOrhfGxp6Jqj72IoExkU7Jb7AM5lI=;
	h=Date:From:To:Subject:References:In-Reply-To:From;
	b=zoNP/qxClJvp87mUTMONtV2EYQCSvLqaeK1EztBKS+OB94hTpFXITL4k8qNtGUNNc
	 JwLe7qS5CDc+LbDYdmNoHlr/UrBJejmL6qoHfd958V6G36CmEdjRrWYAoG8HXw8rIg
	 3oIlfFD9edKxAw27Bu9oyqPiA9Pnrgflpw8eyQ+M=
Date: Thu, 11 Aug 2022 21:57:35 +0000
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH 2/2] pop3d: enable native fcntl locks on all *BSDs
Message-ID: <20220811215735.M757147@dcvr>
References: <20220811200021.12662-1-e@80x24.org>
 <20220811200021.12662-3-e@80x24.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220811200021.12662-3-e@80x24.org>
List-Id: <meta.public-inbox.org>

Eric Wong <e@80x24.org> wrote:
> --- a/lib/PublicInbox/POP3D.pm
> +++ b/lib/PublicInbox/POP3D.pm
> @@ -27,7 +27,7 @@ if ($^O eq 'linux' || $^O eq 'freebsd') {
>  		if ($^O eq 'linux') {
>  			@FLOCK = ("ss\@8$off_t$off_t\@32",
>  				qw(l_type l_whence l_start l_len));
> -		} elsif ($^O eq 'freebsd') {
> +		} elsif ($^O eq /bsd/) {
>  			@FLOCK = ("${off_t}${off_t}lss\@256",
>  				qw(l_start l_len l_pid l_type l_whence));
>  		}

Erm..., will squash the patch below in :x

diff --git a/lib/PublicInbox/POP3D.pm b/lib/PublicInbox/POP3D.pm
index 8aa16907..3fc85efc 100644
--- a/lib/PublicInbox/POP3D.pm
+++ b/lib/PublicInbox/POP3D.pm
@@ -27,7 +27,7 @@ if ($^O eq 'linux' || $^O =~ /bsd/) {
 		if ($^O eq 'linux') {
 			@FLOCK = ("ss\@8$off_t$off_t\@32",
 				qw(l_type l_whence l_start l_len));
-		} elsif ($^O eq /bsd/) {
+		} elsif ($^O =~ /bsd/) {
 			@FLOCK = ("${off_t}${off_t}lss\@256",
 				qw(l_start l_len l_pid l_type l_whence));
 		}