From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id BAC421F59D for ; Thu, 11 Aug 2022 20:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1660248021; bh=43CzTGTSloFAHdbz//Iozd/jCZQ5E/0dakGfsC6NfZA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=PcaC822o3fOgToji3LGEpWkUtY1iIg1Ns4JudQHjLaYlaMHkJF9qiz474bXr4LwSa uh2LlvCGSS5bVbcF1nFAEpg84EBWPu0las0nTLFcqQIQeZN/kApwvD4ksaPHo+fumV RuOiOMZzzbxrl91p+O8FbCpYjqeXzZ8rarcm+d3M= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 1/2] www: inbox: favor "pop3://" over "pop://" Date: Thu, 11 Aug 2022 20:00:20 +0000 Message-Id: <20220811200021.12662-2-e@80x24.org> In-Reply-To: <20220811200021.12662-1-e@80x24.org> References: <20220811200021.12662-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: curl only supports "pop3://" and "pop3s://", despite RFC 2384 existing for "pop://". AFAIK, there's no RFCs for "pop3://" and "pop3s://", but please let us know if there are. In any case, real-world cases like curl are more relevant. --- lib/PublicInbox/Inbox.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm index 3f70e69d..1f7f982d 100644 --- a/lib/PublicInbox/Inbox.pm +++ b/lib/PublicInbox/Inbox.pm @@ -285,9 +285,9 @@ sub pop3_url { my $group = $self->{newsgroup}; my @urls; ($ps && $group) and - @urls = map { m!\Apops?://! ? $_ : "pop://$_" } @$ps; + @urls = map { m!\Apop3?s?://! ? $_ : "pop3://$_" } @$ps; if (my $mi = $self->{'pop3mirror'}) { - my @m = map { m!\Apops?://! ? $_ : "pop://$_" } @$mi; + my @m = map { m!\Apop3?s?://! ? $_ : "pop3://$_" } @$mi; my %seen; # List::Util::uniq requires Perl 5.26+ @urls = grep { !$seen{$_}++ } (@urls, @m); }