unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] www: gzip_filter: avoid errors after ->write failure
@ 2022-08-04 20:08 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2022-08-04 20:08 UTC (permalink / raw)
  To: meta

->zflush must return a string to its caller, not undef.
Additionally, {http_out} may be deleted on ->write if ->close
recurses.

This should fix the following errors:
  Use of uninitialized value $_[1] in string eq at PublicInbox/HTTP.pm line 211.
  E: Can't call method "close" on an undefined value at GzipFilter.pm line 167.

Fixes: a6d50dc1098c01a1 (www: gzip_filter: gracefully handle socket ->write failures, 2022-08-03)
---
 lib/PublicInbox/GzipFilter.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/GzipFilter.pm b/lib/PublicInbox/GzipFilter.pm
index d41748c4..bdd313f5 100644
--- a/lib/PublicInbox/GzipFilter.pm
+++ b/lib/PublicInbox/GzipFilter.pm
@@ -154,7 +154,7 @@ sub zflush ($;$) {
 		$err = $gz->deflate($_[1], $zbuf);
 		die "gzip->deflate: $err" if $err != Z_OK;
 	}
-	$gz // return; # not a bug, recursing on DS->write failure
+	$gz // return ''; # not a bug, recursing on DS->write failure
 	$err = $gz->flush($zbuf);
 	die "gzip->flush: $err" if $err != Z_OK;
 	$zbuf;
@@ -164,7 +164,7 @@ sub close {
 	my ($self) = @_;
 	my $http_out = http_out($self) // return;
 	$http_out->write(zflush($self));
-	delete($self->{http_out})->close;
+	(delete($self->{http_out}) // return)->close;
 }
 
 sub bail  {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-08-04 20:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-04 20:08 [PATCH] www: gzip_filter: avoid errors after ->write failure Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).