From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 66E861F601 for ; Thu, 4 Aug 2022 08:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1659601024; bh=4NtfSXuhD6ShMXDRUNFqbMX4skf5qRtAaWqOxviEvXA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=FjQQsqZ8QTZcelmHZMVf+ON+RDNb9k0WytsdG+s5nMTDqSR//jdufhRU6fGOEF5yv xohaHaFk30UfvCTwBahWhsdB3qzC+zdkoCr0UmvCp1SjNShm8zsdVOIeyipwuriDKX MrvSD0jwjK0zxhrOzgb8Ww1KtL/Np7nWZcqW/HfI= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/7] over: get_xref3: modify rows in-place Date: Thu, 4 Aug 2022 08:16:58 +0000 Message-Id: <20220804081703.1410595-3-e@80x24.org> In-Reply-To: <20220804081703.1410595-1-e@80x24.org> References: <20220804081703.1410595-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: There's no need to create two intermediate arrays when we can modify the existing arrayref. --- lib/PublicInbox/Over.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm index 786f9d92..d6409b2a 100644 --- a/lib/PublicInbox/Over.pm +++ b/lib/PublicInbox/Over.pm @@ -273,13 +273,13 @@ SELECT ibx_id,xnum,oidbin FROM xref3 WHERE docid = ? ORDER BY ibx_id,xnum ASC my $eidx_key_sth = $dbh->prepare_cached(<<'', undef, 1); SELECT eidx_key FROM inboxes WHERE ibx_id = ? - [ map { - my $r = $_; + for my $r (@$rows) { $eidx_key_sth->execute($r->[0]); my $eidx_key = $eidx_key_sth->fetchrow_array; $eidx_key //= "missing://ibx_id=$r->[0]"; - "$eidx_key:$r->[1]:".unpack('H*', $r->[2]); - } @$rows ]; + $r = "$eidx_key:$r->[1]:".unpack('H*', $r->[2]); + } + $rows; } sub next_by_mid {