From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 90CE01F601 for ; Wed, 3 Aug 2022 07:59:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1659513552; bh=cO5xShcZu+vBzCPQLm9P9u9AyXVX/JFTnC95niiFIXI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=4HkMbIikp1LuI28b+E+wVNTL2YV7gzkfv3kY+FignHv0nNg6eZor1xujpwQL3T/2Y przdnZR+hdxJ2dmr0Lo2wlatAubqatihP20BcFiZ5fQ6ktYh8Qs+dRwEsT8aurxJJS rA+XqVpYcYDU/AJhaWBl9pLo0tdAKMcxdzXUhgDE= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/4] www: gzip_filter: update a few comments Date: Wed, 3 Aug 2022 07:59:10 +0000 Message-Id: <20220803075912.10219-3-e@80x24.org> In-Reply-To: <20220803075912.10219-1-e@80x24.org> References: <20220803075912.10219-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: A few things I noticed while reviewing and evaluating the PSGI code for JMAP support. --- lib/PublicInbox/GzipFilter.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/GzipFilter.pm b/lib/PublicInbox/GzipFilter.pm index c586d2f8..d41748c4 100644 --- a/lib/PublicInbox/GzipFilter.pm +++ b/lib/PublicInbox/GzipFilter.pm @@ -1,4 +1,4 @@ -# Copyright (C) 2020-2021 all contributors +# Copyright (C) all contributors # License: AGPL-3.0+ # # In public-inbox <=1.5.0, public-inbox-httpd favored "getline" @@ -116,6 +116,7 @@ sub translate ($$) { } } +# returns PublicInbox::HTTP::{Chunked,Identity} sub http_out ($) { my ($self) = @_; $self->{http_out} // do { @@ -183,7 +184,7 @@ sub bail { # this is public-inbox-httpd-specific sub async_blob_cb { # git->cat_async callback my ($bref, $oid, $type, $size, $self) = @_; - my $http = $self->{env}->{'psgix.io'}; + my $http = $self->{env}->{'psgix.io'}; # PublicInbox::HTTP $http->{forward} or return; # client aborted my $smsg = $self->{smsg} or bail($self, 'BUG: no smsg'); if (!defined($oid)) { @@ -195,7 +196,7 @@ sub async_blob_cb { # git->cat_async callback $smsg->{blob} eq $oid or bail($self, "BUG: $smsg->{blob} != $oid"); eval { $self->async_eml(PublicInbox::Eml->new($bref)) }; bail($self, "E: async_eml: $@") if $@; - if ($self->{-low_prio}) { + if ($self->{-low_prio}) { # run via PublicInbox::WWW::event_step push(@{$self->{www}->{-low_prio_q}}, $self) == 1 and PublicInbox::DS::requeue($self->{www}); } else {