Regexps consume more CPU cycles and memory, and aren't necessary here since we just converted the entire buffer to CRLF. --- lib/PublicInbox/NNTP.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm index 8ad7adc1..b223eb07 100644 --- a/lib/PublicInbox/NNTP.pm +++ b/lib/PublicInbox/NNTP.pm @@ -502,7 +502,7 @@ sub msg_body_write ($$) { # these can momentarily double the memory consumption :< $$msg =~ s/^\./../smg; $$msg =~ s/(?<!\r)\n/\r\n/sg; # Alpine barfs without this - $$msg .= "\r\n" unless $$msg =~ /\r\n\z/s; + $$msg .= "\r\n" unless substr($$msg, -2, 2) eq "\r\n"; $self->msg_more($$msg); }