unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] pop3: reduce memory use while generating the mailbox cache
Date: Sat, 23 Jul 2022 06:12:16 +0000	[thread overview]
Message-ID: <20220723061216.3776894-1-e@80x24.org> (raw)

While the cache itself is relatively compact for 50K messages,
generating it was inefficient due to our schema and Over.pm APIs
being designed for NNTP.  While we won't change our schema for
now, we can choose better DBI APIs to use and limit our ephemeral
memory use.

This amounts to a 60% reduction in memory usage and a 5-10%
speedup against org.kernel.vger.git.0:

	{
		echo 'USER '$(uuidgen)'@org.kernel.vger.git.0'
		echo PASS anonymous
		echo STAT
		echo QUIT
	} | nc $HOST $PORT
---
 lib/PublicInbox/POP3.pm | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/POP3.pm b/lib/PublicInbox/POP3.pm
index 60eedea7..203c91a6 100644
--- a/lib/PublicInbox/POP3.pm
+++ b/lib/PublicInbox/POP3.pm
@@ -148,12 +148,21 @@ sub _stat_cache ($) {
 	my ($self) = @_;
 	my ($beg, $end) = (($self->{uid_dele} // -1) + 1, $self->{uid_max});
 	PublicInbox::IMAP::uid_clamp($self, \$beg, \$end);
-	my $opt = { limit => PublicInbox::IMAP::UID_SLICE };
-	my $m = $self->{ibx}->over(1)->do_get(<<'', $opt, $beg, $end);
+	my (@cache, $m);
+	my $sth = $self->{ibx}->over(1)->dbh->prepare_cached(<<'', undef, 1);
 SELECT num,ddd FROM over WHERE num >= ? AND num <= ?
 ORDER BY num ASC
 
-	[ map { ($_->{num}, $_->{bytes} + 0, $_->{blob}) } @$m ];
+	$sth->execute($beg, $end);
+	do {
+		$m = $sth->fetchall_arrayref({}, 1000);
+		for my $x (@$m) {
+			PublicInbox::Over::load_from_row($x);
+			push(@cache, $x->{num}, $x->{bytes} + 0, $x->{blob});
+			undef $x; # saves ~1.5M memory w/ 50k messages
+		}
+	} while (scalar(@$m) && ($beg = $cache[-3] + 1));
+	\@cache;
 }
 
 sub cmd_stat {

                 reply	other threads:[~2022-07-23  6:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220723061216.3776894-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).