From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 15FD81F61F for ; Sat, 23 Jul 2022 04:41:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1658551317; bh=Wi5FGKYVcPXR27d/Yr/qGDQqEdjz4eRWJXD/IBE69hQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=N6x132wJ9mU0SY0fLC5mhD9zEaGfSFVjfPSmXo+cODuq7GQTYkcqwy83N1jvbByl0 h02afdl4jX0mF3sOj6j49Sv+R32ehsuyorUTLKV8+JDz7WqiB3VNq5nJCjOQailjwb A/lqF4cxgftdWIOWUknZqkf74tlxYa21K4gMDI68= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 07/11] nntp: listgroup_range_i: remove useless `map' op Date: Sat, 23 Jul 2022 04:41:51 +0000 Message-Id: <20220723044155.3733949-8-e@80x24.org> In-Reply-To: <20220723044155.3733949-1-e@80x24.org> References: <20220723044155.3733949-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: No need to iterate through the array twice; and this even seems a hair faster than what I got with commit 726d6e71aee5d974 (nntp: small speed up for multi-line responses, 2020-12-04) --- lib/PublicInbox/NNTP.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm index 43219b36..ab6eb525 100644 --- a/lib/PublicInbox/NNTP.pm +++ b/lib/PublicInbox/NNTP.pm @@ -189,7 +189,7 @@ sub listgroup_range_i { my ($self, $beg, $end) = @_; my $r = $self->{ibx}->mm(1)->msg_range($beg, $end, 'num'); scalar(@$r) or return; - $self->msg_more(join('', map { "$_->[0]\r\n" } @$r)); + $self->msg_more(join("\r\n", @$r, '')); 1; }