From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id C38781F4D7 for ; Sun, 8 May 2022 22:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1652047831; bh=lyCAAcLYTBn/5rz6Kr1zwIP0INH2Nh+eFppiteqA6us=; h=From:To:Subject:Date:From; b=FsDoPUSaVia+VqXIilO5gbRhBia2bU2iVuTsu7qvVBqez5BMSNJKmNaPEgD9kVe1y RSYD5sTCL+P2ICbtiQ+cIGh86XjV9bsPNI9MGsmAUsqlCiK2kFmIMdii26AmvW4qHK jnvcjQkforFYOZ5OT/W2nB7egAL1l6L2ppLUlCuU= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] daemon: fix uninitialized variable Date: Sun, 8 May 2022 22:10:31 +0000 Message-Id: <20220508221031.31386-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: And also replace an unnecessary substitution (s///) op with a match (m//). Fixes: 93a7b219d58aad86 ("public-inbox-netd: a multi-protocol superserver") --- lib/PublicInbox/Daemon.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/Daemon.pm b/lib/PublicInbox/Daemon.pm index 13cce1ec..d08ce0f9 100644 --- a/lib/PublicInbox/Daemon.pm +++ b/lib/PublicInbox/Daemon.pm @@ -618,9 +618,9 @@ sub daemon_loop ($) { while (my ($k, $v) = each %tls_opt) { my $l = $k; $l =~ s!\A([^:]+)://!!; - my $scheme = $1; + my $scheme = $1 // ''; my $xn = $xnetd->{$l} // $xnetd->{''}; - if ($scheme =~ s!\A(?:https|imaps|nntps)!!) { + if ($scheme =~ m!\A(?:https|imaps|nntps)!) { $post_accept{$l} = tls_start_cb($v, $xn->{post_accept}); } elsif ($xn->{tlsd}) { # STARTTLS, $k eq '' is OK $xn->{tlsd}->{accept_tls} = $v;