From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id A4FEB1F4DA for ; Sat, 23 Apr 2022 22:03:41 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/2] lei: move to v5.12 to avoid "use strict" Date: Sat, 23 Apr 2022 22:03:41 +0000 Message-Id: <20220423220341.28760-3-e@80x24.org> In-Reply-To: <20220423220341.28760-1-e@80x24.org> References: <20220423220341.28760-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Socket.pm still loads strict.pm, unfortunately, which hurts startup time; but we'll save some LoC this way. --- lib/PublicInbox/CmdIPC4.pm | 3 +-- lib/PublicInbox/LEI.pm | 3 +-- lib/PublicInbox/Spawn.pm | 2 +- lib/PublicInbox/Syscall.pm | 3 +-- script/lei | 3 +-- 5 files changed, 5 insertions(+), 9 deletions(-) diff --git a/lib/PublicInbox/CmdIPC4.pm b/lib/PublicInbox/CmdIPC4.pm index 76938b6d..e368d032 100644 --- a/lib/PublicInbox/CmdIPC4.pm +++ b/lib/PublicInbox/CmdIPC4.pm @@ -5,8 +5,7 @@ # first choice for script/lei front-end and 2nd choice for lei backend # libsocket-msghdr-perl is in Debian but not many other distros as of 2021. package PublicInbox::CmdIPC4; -use strict; -use v5.10.1; +use v5.12; use Socket qw(SOL_SOCKET SCM_RIGHTS); BEGIN { eval { require Socket::MsgHdr; # XS diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index 93b4ea03..89aa4119 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -6,8 +6,7 @@ # local clients with read/write access to the FS and use as many # system resources as the local user has access to. package PublicInbox::LEI; -use strict; -use v5.10.1; +use v5.12; use parent qw(PublicInbox::DS PublicInbox::LeiExternal PublicInbox::LeiQuery); use Getopt::Long (); diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm index 137b8087..3f69108a 100644 --- a/lib/PublicInbox/Spawn.pm +++ b/lib/PublicInbox/Spawn.pm @@ -15,7 +15,7 @@ # We don't want too many DSOs: https://udrepper.livejournal.com/8790.html package PublicInbox::Spawn; -use strict; +use v5.12; use parent qw(Exporter); use Symbol qw(gensym); use Fcntl qw(LOCK_EX SEEK_SET); diff --git a/lib/PublicInbox/Syscall.pm b/lib/PublicInbox/Syscall.pm index 22b779ad..777c44d0 100644 --- a/lib/PublicInbox/Syscall.pm +++ b/lib/PublicInbox/Syscall.pm @@ -16,8 +16,7 @@ # You may distribute under the terms of either the GNU General Public # License or the Artistic License, as specified in the Perl README file. package PublicInbox::Syscall; -use strict; -use v5.10.1; +use v5.12; use parent qw(Exporter); use POSIX qw(ENOENT ENOSYS EINVAL O_NONBLOCK); use Socket qw(SOL_SOCKET SCM_RIGHTS); diff --git a/script/lei b/script/lei index adef9944..5feb7751 100755 --- a/script/lei +++ b/script/lei @@ -1,8 +1,7 @@ #!perl -w # Copyright (C) all contributors # License: AGPL-3.0+ -use strict; -use v5.10.1; +use v5.12; use Socket qw(AF_UNIX SOCK_SEQPACKET MSG_EOR pack_sockaddr_un); use PublicInbox::CmdIPC4; my $narg = 5;