unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: meta@public-inbox.org
Subject: Re: test: 'seen set from rename' potentially racy
Date: Sun, 13 Feb 2022 21:01:59 +0000	[thread overview]
Message-ID: <20220213210159.GA9364@dcvr> (raw)
In-Reply-To: <20211104185149.GA9220@dcvr>

Eric Wong <e@80x24.org> wrote:
> Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> > Hello:
> > 
> > I was having some trouble using "make check" on the Fedora build system:
> > 
> > #   Failed test 'seen set from rename'
> > #   at t/lei-watch.t line 61.
> > #                   '/tmp/pi-lei-watch-11080-FYz2/lei-daemon/md2/cur/9bf1002c49eb075df47247b74d69bcd555e23422=99:2,'
> > #     doesn't match '(?^:S\z)'
> > # [
> > #   '/tmp/pi-lei-watch-11080-FYz2/lei-daemon/md2/cur/9bf1002c49eb075df47247b74d69bcd555e23422=99:2,'
> > # ]
> > 
> > This wasn't happening in my own chroot builds, so I'm suspecting that the
> > faster system on the Fedora build infra side is causing this failure,
> > therefore perhaps some kind of race condition. 
> 
> Hmm, I thought I fixed it...  Does increasing the tick sleep time help?

Nope, 5fb5b6d1a62b74b3 (t/lei-watch: test with with higher sleep, 2021-11-10)
didn't help...

> 
> > https://download.copr.fedorainfracloud.org/results/icon/b4/fedora-35-x86_64/02928611-public-inbox/build.log.gz
> 
> "prove --state=save -bvw -j3", so 2 cores?  Any idea what
> CONFIG_HZ is on that system?
> 
> > Switching to "make test" seems to help, which is what I've done for now.
> 
> OK, so it could be load related.  There could probably be a way
> to "subscribe" for updates to lei-daemon so sleeping wouldn't be
> necessary.  I'll see abouit it next week, got some other stuff
> to take care of...

That's on the table in case I get my mind back or somebody else
helps.  I haven't been able to work on anything requiring
original thought in months (not that it's ever been great), so I
think disabling flaky tests for now is the least bad option:

---------------8<-----------
Subject: [PATCH] t/lei-*watch: disable flaky tests by default for now

Properly fixing these tests is too difficult for me at the
moment, so just disable these tests for now.  A proper fix and
fleshing out support for inotify will hopefully happen at some
point.
---
 t/lei-auto-watch.t | 1 +
 t/lei-watch.t      | 1 +
 2 files changed, 2 insertions(+)

diff --git a/t/lei-auto-watch.t b/t/lei-auto-watch.t
index d5661ae5..f871188d 100644
--- a/t/lei-auto-watch.t
+++ b/t/lei-auto-watch.t
@@ -3,6 +3,7 @@
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 use strict; use v5.10.1; use PublicInbox::TestCommon;
 use File::Basename qw(basename);
+plan skip_all => "TEST_FLAKY not enabled for $0" if !$ENV{TEST_FLAKY};
 my $have_fast_inotify = eval { require Linux::Inotify2 } ||
 	eval { require IO::KQueue };
 $have_fast_inotify or
diff --git a/t/lei-watch.t b/t/lei-watch.t
index e6066033..24d9f5c8 100644
--- a/t/lei-watch.t
+++ b/t/lei-watch.t
@@ -3,6 +3,7 @@
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 use strict; use v5.10.1; use PublicInbox::TestCommon;
 use File::Path qw(make_path remove_tree);
+plan skip_all => "TEST_FLAKY not enabled for $0" if !$ENV{TEST_FLAKY};
 require_mods('lei');
 my $have_fast_inotify = eval { require Linux::Inotify2 } ||
 	eval { require IO::KQueue };

      reply	other threads:[~2022-02-13 21:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 13:43 test: 'seen set from rename' potentially racy Konstantin Ryabitsev
2021-11-04 18:51 ` Eric Wong
2022-02-13 21:01   ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220213210159.GA9364@dcvr \
    --to=e@80x24.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).