From: Eric Wong <e@80x24.org>
To: Julien Moutinho <julm+public-inbox@sourcephile.fr>
Cc: Dominique Martinet <asmadeus@codewreck.org>, meta@public-inbox.org
Subject: FD_CLOEXEC w/ nix-shell [was: Test failures with 1.7.0]
Date: Tue, 1 Feb 2022 23:27:40 +0000 [thread overview]
Message-ID: <20220201232740.M97535@dcvr> (raw)
In-Reply-To: <20211209013743.okzgim7bbrpahks7@sourcephile.fr>
Julien Moutinho <julm+public-inbox@sourcephile.fr> wrote:
> Without Inline::C, and without Nix's sandbox
> --------------------------------------------
>
> I get 3 tests to fail (in addition to those currently disabled in Nixpkgs:
> https://github.com/NixOS/nixpkgs/pull/104457/files#diff-77474340b38081fea7ce3b112c1bc060d3a95cc5e781915463e2f3fc5556da7bR34-R69
> ie. convert-compact, search, v2writable, www_listing, eml, hl_mod,
> lei-mirror and spawn):
> $ nix develop -f . public-inbox
> $ doCheck= bash pkgs/development/perl-modules/generic/builder.sh
> $ make -C public-inbox-1.7.0 test
> > [...]
> > Test Summary Report
> > -------------------
> > t/nntpd-v2.t (Wstat: 256 Tests: 113 Failed: 1)
> > Failed test: 102
> > Non-zero exit status: 1
> > t/nntpd.t (Wstat: 256 Tests: 110 Failed: 1)
> > Failed test: 99
> > Non-zero exit status: 1
> > t/solver_git.t (Wstat: 1280 Tests: 13 Failed: 5)
> > Failed tests: 9-13
> > Non-zero exit status: 5
> > Parse errors: No plan found in TAP output
> > Files=149, Tests=4658, 296 wallclock secs ( 1.78 usr 0.56 sys + 116.73 cusr 165.82 csys = 284.89 CPU)
> > Result: FAIL
> > Failed 3/149 test programs. 7/4658 subtests failed.
>
> More precisely:
> $ (cd public-inbox-1.7.0; perl -I$out/lib/perl5/site_perl t/nntpd-v2.t )
> > [...]
> > ok 101 - new article retrieved after compact
> > not ok 102 - no deleted files
> > # Failed test 'no deleted files'
> > # at ./t/nntpd.t line 363.
> > # Structures begin differing at:
> > # $got->[0] = '-nntpd 3130714 julm 4u REG 0,53 77189 2606550 /tmp/nix-shell.D0VGvX (deleted)
OK, so that's a false positive for a deleted file that wasn't
created by public-inbox. I suppose our tests can be altered to
account for that.
Is nix-shell setting FD_CLOEXEC on all FDs (>= 3) it creates?
IMNSHO it should.
It seems to be standard practice nowadays to set FD_CLOEXEC on
all FDs (>=3) created. At least that's my experience with Perl
5.6+ and Ruby 2.0+; I'll let experts in other languages chime in
for other stuff...
More on the rest in a separate email(s).
next prev parent reply other threads:[~2022-02-01 23:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 1:07 Test failures with 1.7.0 Julien Moutinho
2021-12-08 4:08 ` Eric Wong
2021-12-08 10:56 ` Dominique Martinet
2021-12-08 18:22 ` [PATCH] nodatacow: quiet chattr errors [was: Test failures with 1.7.0] Eric Wong
2021-12-08 21:14 ` Dominique Martinet
2021-12-08 22:01 ` Dominique Martinet
2022-01-30 21:49 ` Eric Wong
2022-01-30 23:18 ` Dominique Martinet
2022-01-31 2:03 ` Eric Wong
2022-01-31 3:34 ` Dominique Martinet
2022-02-01 1:27 ` Eric Wong
2021-12-09 1:37 ` Test failures with 1.7.0 Julien Moutinho
2021-12-09 2:53 ` Dominique Martinet
2022-02-01 9:37 ` Eric Wong
2022-02-01 23:27 ` Eric Wong [this message]
2022-02-02 0:23 ` FD_CLOEXEC w/ nix-shell [was: Test failures with 1.7.0] Dominique Martinet
2022-02-02 2:11 ` Dominique Martinet
2022-02-01 23:34 ` [PATCH] test_lei: use consistent locale for error messages Eric Wong
2022-02-17 21:02 ` [PATCH] t/lei-sigpipe: attempt to improve diagnostics for stuck test Eric Wong
2022-02-20 1:38 ` Julien Moutinho
2022-02-22 6:44 ` Eric Wong
2022-02-27 4:15 ` Julien Moutinho
2022-02-27 6:41 ` Julien Moutinho
2022-02-27 7:23 ` Dominique Martinet
2022-02-27 8:04 ` Julien Moutinho
2022-02-27 11:17 ` [PATCH] t/lei-sigpipe: ensure SIGPIPE is unblocked for this test Eric Wong
2022-03-11 10:42 ` [PATCH] t/lei-sigpipe.t: ensure SIGPIPE is not ignored instead of not blocked Julien Moutinho
2022-03-14 22:14 ` Eric Wong
2022-03-15 2:56 ` Julien Moutinho
2022-03-01 2:30 ` Test failures with 1.7.0 Julien Moutinho
2022-03-01 4:05 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201232740.M97535@dcvr \
--to=e@80x24.org \
--cc=asmadeus@codewreck.org \
--cc=julm+public-inbox@sourcephile.fr \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).