unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] http: don't send chunk finalizer on HEAD responses
@ 2022-01-30 22:31 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2022-01-30 22:31 UTC (permalink / raw)
  To: meta

AFAIK this doesn't affect Varnish or nginx users, but those
should eventually become optional dependencies.
---
 lib/PublicInbox/HTTP.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index e65988be..76e978a2 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -185,6 +185,7 @@ sub response_header_write {
 	my $alive;
 	if (!$term && $prot_persist) { # auto-chunk
 		$chunked = $alive = 2;
+		$alive = 3 if $env->{REQUEST_METHOD} eq 'HEAD';
 		$h .= "Transfer-Encoding: chunked\r\n";
 		# no need for "Connection: keep-alive" with HTTP/1.1
 	} elsif ($term && ($prot_persist || ($conn =~ /\bkeep-alive\b/i))) {
@@ -224,6 +225,7 @@ sub identity_write ($$) {
 sub response_done {
 	my ($self, $alive) = @_;
 	delete $self->{env}; # we're no longer busy
+	# HEAD requests set $alive = 3 so we don't send "0\r\n\r\n";
 	$self->write(\"0\r\n\r\n") if $alive == 2;
 	$self->write($alive ? $self->can('requeue') : \&close);
 }
@@ -288,7 +290,7 @@ sub response_write {
 			getline_pull($self); # kick-off!
 		}
 	# these are returned to the calling application:
-	} elsif ($alive == 2) {
+	} elsif ($alive >= 2) {
 		bless [ $self, $alive ], 'PublicInbox::HTTP::Chunked';
 	} else {
 		bless [ $self, $alive ], 'PublicInbox::HTTP::Identity';

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-01-30 22:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-30 22:31 [PATCH] http: don't send chunk finalizer on HEAD responses Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).