From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin@linuxfoundation.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS3215 2.6.0.0/16
X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
	SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham
	autolearn_force=no version=3.4.2
Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id 139EF1F953
	for <meta@public-inbox.org>; Mon,  8 Nov 2021 21:36:16 +0000 (UTC)
Received: by mail-qv1-xf2e.google.com with SMTP id gu12so5441267qvb.6
        for <meta@public-inbox.org>; Mon, 08 Nov 2021 13:36:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linuxfoundation.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to;
        bh=Ky/FsnVeSPZ1qFTpV9ggGkC05PrJ0/S9MnEDYsj0xQc=;
        b=GxzvY2JMLq9wLxYf0tFRKzNjc0L75IN7itFeQvLQ4Hi0YkuXDa3I6x+ccXLYhydT5V
         VQ37N1P5QbjL83zCR2zhqLcRzedTfBTrreuLWEUZ4pRjSZQ0UkuLYMCLGO+aIylQgbBl
         dkoF0OrvnPKNYPolnApsbd7j3ZcHCzDKosY6s=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=Ky/FsnVeSPZ1qFTpV9ggGkC05PrJ0/S9MnEDYsj0xQc=;
        b=aMvTcKf+Xct8oMGuWD4GH6UrUB6lKJFPZ9v/6EN/+oyR+OKTG+i4m8qrGBwaCG3X33
         LydPeQoZnSM2LJ72PV7ixjpJ0y2jZTIExi3BNZ3Y4KKq4nP8ZLJb3Inmxz3s0na++XOe
         34ugcFj5AZ8QAz4On8PebiMX73CFy1H3/lpKLmjHDPPOkoFLS5oS6gRfycwsU8172r0i
         ZqK+F0G4it8Mxr1ExLCsYUnffFZAspXl6bdRXalzXcwDHuUoxS/QVAHJ0EKdm+ygSau3
         3MTJA3mM5b8sluGRMUvYPQph/daur5AKi+pwmyUh2ECoDIuitiAIHx7uWDKrboop4TR2
         Z38A==
X-Gm-Message-State: AOAM531eFLAV7D0zT4H58gcLdB8l0uq+l1iDcpSD30n9Gwl6AM40VlVu
	NHaZrzhMcybpIS/EmmN3iUsmhg==
X-Google-Smtp-Source: ABdhPJylm2ddqLL68rQdm3IVyr33iWWaR/RGYT50f58lNgohBzCASXTlm9AEIyq1PV4HmyEh1fs6ZA==
X-Received: by 2002:ad4:5f88:: with SMTP id jp8mr2083466qvb.57.1636407374987;
        Mon, 08 Nov 2021 13:36:14 -0800 (PST)
Received: from meerkat.local (bras-base-mtrlpq5031w-grc-32-216-209-220-181.dsl.bell.ca. [216.209.220.181])
        by smtp.gmail.com with ESMTPSA id w9sm10730820qko.19.2021.11.08.13.36.14
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 08 Nov 2021 13:36:14 -0800 (PST)
Date: Mon, 8 Nov 2021 16:36:13 -0500
From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Eric Wong <e@80x24.org>
Cc: Rob Herring <robh@kernel.org>, meta@public-inbox.org,
	workflows@vger.kernel.org
Subject: Re: lei: incorrect quoting on saved searches (was Re: lore+lei:
 getting started)
Message-ID: <20211108213613.4hjtbokwzar7x4ph@meerkat.local>
References: <lorelei.part1.202111051304.mdtebsxahljcrxak@meerkat.local>
 <CAL_JsqJBh1O3H2-P07AHzVq0x89BoP_N6P=rT5up6=3QyF_B0Q@mail.gmail.com>
 <20211108202204.q5zg6bachnvbjlnx@meerkat.local>
 <20211108204923.GA12823@dcvr>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211108204923.GA12823@dcvr>
List-Id: <meta.public-inbox.org>

On Mon, Nov 08, 2021 at 08:49:23PM +0000, Eric Wong wrote:
> Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> > On Mon, Nov 08, 2021 at 01:49:07PM -0600, Rob Herring wrote:
> > 
> > Moving this to meta.
> 
> I don't think workflows should've been dropped, though.
> 
> > > >     lei q -I https://lore.kernel.org/all/ -o ~/Mail/floppy \
> > > >       --threads --dedupe=mid \
> > > >       '(dfn:drivers/block/floppy.c OR dfhh:floppy_* OR s:floppy \
> > > >       OR ((nq:bug OR nq:regression) AND nq:floppy)) \
> > > >       AND rt:1.month.ago..'
> > > 
> > > I tried a similar one which I had working as a bookmark:
> 
> That's actually treating the entire single-quoted section as
> a phrase search for Xapian.

Hmm... I noticed that when I `lei edit-search` the initial query that was
causing quoting issues, I get the following:

	[lei]
		q = (dfn:drivers OR dfn:arch OR dfn:Documentation OR dfn:include OR dfn:scripts) AND f:robh@kernel.org

So, the extra quotes didn't get added to the config file. Running `lei up` on
that saved search seems to do the right thing, so the erroneous quotes are
only added during the initial `lei q` call.

> The correct way to use '(', ')', and '*' on the command-line for
> Xapian is to shell escape them:

But putting them into single quotes should accomplish the same result, no? At
least, that's how I've always understood shell escaping.

-K