From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id E96561F670; Tue, 26 Oct 2021 05:28:15 +0000 (UTC) Date: Tue, 26 Oct 2021 05:28:15 +0000 From: Eric Wong To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= Cc: meta@public-inbox.org Subject: Re: [PATCH] t/index-git-times: support non-master default branch Message-ID: <20211026052815.GA13265@dcvr> References: <20211025222453.252181-1-thomas@t-8ch.de> <20211025225822.GA28875@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: Thomas Weißschuh wrote: > On 2021-10-25 16:58-0600, Eric Wong wrote: > > Thanks, pushed as 9f3fb207. It looks like there's several > > other tests broken with non-master being the default. Can we > > expect fixes for those, too? Thanks again. > > Which tests are failing for you? t/edit.t t/indexlevels-mirror.t t/indexlevels-mirror-v1.t t/convert-compact.t t/multi-mid.t t/feed.t I was testing with --global, since that's what I expect if users are going to change their default branch. $ git config --global init.defaultBranch foo $ make check-run All the "not ok" lines: # t/edit.log: not ok 1 - -F FILE edit OK # t/edit.log: not ok 2 - -F FILE message edited # t/edit.log: not ok 3 - -F FILE shows commit on success # t/edit.log: not ok 4 - -m MESSAGE_ID edit OK # t/edit.log: not ok 5 - -m MESSAGE_ID message edited # t/edit.log: not ok 6 - -m MESSAGE_ID shows commit on success # t/edit.log: not ok 7 - no-op -m MESSAGE_ID succeeds # t/edit.log: not ok 9 - no-op -m MESSAGE_ID does not change message # t/edit.log: not ok 10 - noop shows NONE # t/edit.log: not ok 12 - no-op -m MESSAGE_ID w/Status: header succeeds # t/edit.log: not ok 14 - no-op -m MESSAGE_ID w/Status: header does not change message # t/edit.log: not ok 16 - noop shows NONE # t/edit.log: not ok 18 - -m MESSAGE_ID can change Received: headers succeeds # t/edit.log: not ok 19 - -m MESSAGE_ID can change Received: headers does not change Subject # t/edit.log: not ok 20 - added Received header # t/edit.log: not ok 24 - non-interactive editor failure shows error # t/edit.log: not ok 26 - mailEditor set in config edited message # t/edit.log: not ok 27 - mailEditor set in config message edited # t/edit.log: not ok 29 - --raw and mbox escaping succeeds # t/edit.log: not ok 30 - put "From " line into body # t/edit.log: not ok 31 - --raw and mbox escaping succeeds with mbox escaping # t/edit.log: not ok 32 - changed "From " line unescaped # t/edit.log: not ok 33 - --raw and mbox escaping succeeds again # t/edit.log: not ok 37 - edit ambiguous Message-ID with -m fails w/o --force # t/edit.log: not ok 38 - edit ambiguous Message-ID with -m shows matches # t/edit.log: not ok 41 - edit ambiguous Message-ID with -m and --force notes all will be edited # t/edit.log: not ok 42 - edit ambiguous Message-ID with -m and --force edited both messages # t/indexlevels-mirror.log: not ok 12 - 2nd message seen in mirror # t/indexlevels-mirror.log: not ok 13 - got both messages in mirror # t/indexlevels-mirror.log: not ok 15 - 2nd message seen in master # t/indexlevels-mirror.log: not ok 16 - got both messages in master # t/indexlevels-mirror.log: not ok 17 - master has expected NNTP articles # t/indexlevels-mirror.log: not ok 18 - mirror has expected NNTP articles # t/indexlevels-mirror.log: not ok 19 - 2nd message removed # t/indexlevels-mirror.log: not ok 32 - v2 mirror matches master articles # t/indexlevels-mirror.log: not ok 46 - 2nd message seen in mirror # t/indexlevels-mirror.log: not ok 47 - got both messages in mirror # t/indexlevels-mirror.log: not ok 49 - 2nd message seen in master # t/indexlevels-mirror.log: not ok 50 - got both messages in master # t/indexlevels-mirror.log: not ok 51 - master has expected NNTP articles # t/indexlevels-mirror.log: not ok 52 - mirror has expected NNTP articles # t/indexlevels-mirror.log: not ok 53 - 2nd message removed # t/indexlevels-mirror.log: not ok 57 - v2 found m@2 via Xapian on medium # t/indexlevels-mirror.log: not ok 69 - v2 mirror matches master articles # t/indexlevels-mirror.log: not ok 83 - 2nd message seen in mirror # t/indexlevels-mirror.log: not ok 84 - got both messages in mirror # t/indexlevels-mirror.log: not ok 86 - 2nd message seen in master # t/indexlevels-mirror.log: not ok 87 - got both messages in master # t/indexlevels-mirror.log: not ok 88 - master has expected NNTP articles # t/indexlevels-mirror.log: not ok 89 - mirror has expected NNTP articles # t/indexlevels-mirror.log: not ok 90 - 2nd message removed # t/indexlevels-mirror.log: not ok 94 - v2 found m@2 via Xapian on full # t/indexlevels-mirror.log: not ok 106 - v2 mirror matches master articles # t/indexlevels-mirror-v1.log: not ok 12 - 2nd message seen in mirror # t/indexlevels-mirror-v1.log: not ok 13 - got both messages in mirror # t/indexlevels-mirror-v1.log: not ok 18 - mirror has expected NNTP articles # t/indexlevels-mirror-v1.log: not ok 31 - v1 mirror matches master articles # t/indexlevels-mirror-v1.log: not ok 45 - 2nd message seen in mirror # t/indexlevels-mirror-v1.log: not ok 46 - got both messages in mirror # t/indexlevels-mirror-v1.log: not ok 51 - mirror has expected NNTP articles # t/indexlevels-mirror-v1.log: not ok 56 - v1 found m@2 via Xapian on medium # t/indexlevels-mirror-v1.log: not ok 68 - v1 mirror matches master articles # t/indexlevels-mirror-v1.log: not ok 82 - 2nd message seen in mirror # t/indexlevels-mirror-v1.log: not ok 83 - got both messages in mirror # t/indexlevels-mirror-v1.log: not ok 88 - mirror has expected NNTP articles # t/indexlevels-mirror-v1.log: not ok 93 - v1 found m@2 via Xapian on full # t/indexlevels-mirror-v1.log: not ok 105 - v1 mirror matches master articles # t/convert-compact.log: not ok 36 - message exists in history # t/multi-mid.log: not ok 2 - no errors or warnings from -convert # t/multi-mid.log: not ok 4 - v2 conversion times match # t/multi-mid.log: not ok 7 - v2 clone times match # t/multi-mid.log: not ok 9 - no errors or warnings from -convert # t/multi-mid.log: not ok 11 - v2 conversion times match # t/multi-mid.log: not ok 14 - v2 clone times match # t/feed.log: not ok 9 - spam showed up :< > The only failures I still see are in t/lei-q-remote-import.t which is unrelated > to the git branch and some more that fail only during parallel test execution. > > In t/lei-q-remote-import.t it seems the search results are not memoized to the > local store. (See attachment) Thanks, I'll check out lei-q-remote-import.t separately. That could be related to SMP or slow/fast storage. Any details you can share about CPU core count, speeds or storage speeds, or CPU scheduler, CONFIG_HZ?