From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] viewvcs: die on tmpfile() errors
Date: Sun, 24 Oct 2021 01:45:22 +0000 [thread overview]
Message-ID: <20211024014522.29173-1-e@80x24.org> (raw)
Just let Plack::Util::run_app catch the error and generate
a 500 response for it.
---
lib/PublicInbox/ViewVCS.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 021b70cf..3cbc363b 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -194,7 +194,7 @@ sub show ($$;$) {
$hints->{$to} = $v if $v ne '';
}
- $ctx->{'log'} = tmpfile("solve.$oid_b");
+ $ctx->{'log'} = tmpfile("solve.$oid_b") // die "tmpfile: $!";
$ctx->{fn} = $fn;
my $solver = PublicInbox::SolverGit->new($ctx->{ibx},
\&solve_result, $ctx);
reply other threads:[~2021-10-24 1:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211024014522.29173-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).