From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id A8A581F9F3 for ; Fri, 24 Sep 2021 10:56:45 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/5] fetch: fix skipping with multi-epoch inboxes Date: Fri, 24 Sep 2021 10:56:42 +0000 Message-Id: <20210924105645.8627-3-e@80x24.org> In-Reply-To: <20210924105645.8627-1-e@80x24.org> References: <20210924105645.8627-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We need to check every epoch for writability, so don't break out of the loop when we find a URL. --- lib/PublicInbox/Fetch.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/Fetch.pm b/lib/PublicInbox/Fetch.pm index 0bd6502c..464ffe12 100644 --- a/lib/PublicInbox/Fetch.pm +++ b/lib/PublicInbox/Fetch.pm @@ -112,10 +112,10 @@ sub do_fetch { # main entry point $skip->{$nr} = 1; next; } + next if defined $git_url; if (defined(my $url = remote_url($lei, $edir))) { $git_url = $url; $epoch = $nr; - last; } else { warn "W: $edir missing remote.origin.url\n"; }