From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id C1AF21F8C8
	for <meta@public-inbox.org>; Sat, 18 Sep 2021 10:41:56 +0000 (UTC)
Date: Sat, 18 Sep 2021 10:41:56 +0000
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH 7/9] net_reader: support imaps:// w/ socks5h:// proxy
Message-ID: <20210918104156.GA3246@dcvr>
References: <20210918093332.16054-1-e@80x24.org>
 <20210918093332.16054-8-e@80x24.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210918093332.16054-8-e@80x24.org>
List-Id: <meta.public-inbox.org>

Eric Wong <e@80x24.org> wrote:
> +			$s = IO::Socket::SSL->start_SSL($s) or
> +				"E: <$uri> ".(IO::Socket::SSL->errstr // '');

Oops, I missed a die() and missed the warning when running tests :x

-----8<----
diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm
index 28e20d38..ccfdd261 100644
--- a/lib/PublicInbox/NetReader.pm
+++ b/lib/PublicInbox/NetReader.pm
@@ -57,7 +57,7 @@ sub mic_new ($$$$) {
 			"E: <$uri> ".eval('$IO::Socket::Socks::SOCKS_ERROR');
 		if ($mic_arg->{Ssl}) { # for imaps://
 			require IO::Socket::SSL;
-			$s = IO::Socket::SSL->start_SSL($s) or
+			$s = IO::Socket::SSL->start_SSL($s) or die
 				"E: <$uri> ".(IO::Socket::SSL->errstr // '');
 		}
 		$mic_arg{Socket} = $s;