From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 0/3] lei saved-search fixes
Date: Sat, 11 Sep 2021 00:19:14 +0000 [thread overview]
Message-ID: <20210911001917.1310-1-e@80x24.org> (raw)
In-Reply-To: <20210910141157.6u5adehpx7wftkor@meerkat.local>
Konstantin Ryabitsev wrote:
> I think it's reasonable to normalize \s+ into a single space for all queries,
> right?
Yes, 3/3 does it for HTTP(S). Don't think it's needed for local
queries. I'm leaving non-ASCII whitespace alone for now since I
don't think it'd be a real problem.
> Another observation is that when I missed a \ on one of the lines, I managed
> to make lei unusable. :)
That's a far more important problem fixed in 1/3 :>
Eric Wong (3):
lei: fix handling of broken lei.saved-search config files
lei: pass client stderr to git-config in more places
lei: normalize whitespace in remote queries
lib/PublicInbox/Config.pm | 10 ++--
lib/PublicInbox/LEI.pm | 23 +++++++--
lib/PublicInbox/LeiEditSearch.pm | 79 +++++++++++++++++++++++++++++--
lib/PublicInbox/LeiMirror.pm | 4 +-
lib/PublicInbox/LeiSavedSearch.pm | 77 ++++++------------------------
lib/PublicInbox/LeiXSearch.pm | 4 +-
script/lei | 2 +
t/lei-q-save.t | 17 +++++++
8 files changed, 136 insertions(+), 80 deletions(-)
next prev parent reply other threads:[~2021-09-11 0:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 14:11 RFC: normalize whitespace in lei queries Konstantin Ryabitsev
2021-09-11 0:19 ` Eric Wong [this message]
2021-09-11 0:19 ` [PATCH 1/3] lei: fix handling of broken lei.saved-search config files Eric Wong
2021-09-11 0:19 ` [PATCH 2/3] lei: pass client stderr to git-config in more places Eric Wong
2021-09-11 0:19 ` [PATCH 3/3] lei: normalize whitespace in remote queries Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210911001917.1310-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).