From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 7804A1F8C6; Thu, 9 Sep 2021 21:34:36 +0000 (UTC) Date: Thu, 9 Sep 2021 21:34:36 +0000 From: Eric Wong To: Konstantin Ryabitsev Cc: meta@public-inbox.org Subject: Re: [PATCH] gcf2: die if pkg-config is missing Message-ID: <20210909213436.GA31770@dcvr> References: <20210909182350.yzhdw3znylowb3im@meerkat.local> <20210909204541.GA11866@dcvr> <20210909210138.ssiv5tri65mf4l4o@meerkat.local> <20210909211436.GA29028@dcvr> <20210909212105.qbrdlu37b6bbz2ij@meerkat.local> <20210909212348.GA31420@dcvr> <20210909212933.adpgxheppjnorncd@meerkat.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210909212933.adpgxheppjnorncd@meerkat.local> List-Id: Konstantin Ryabitsev wrote: > On Thu, Sep 09, 2021 at 09:23:48PM +0000, Eric Wong wrote: > > > Annoyingly, after I blow away the container to start fresh, I get: > > > > > > t/gcf2.t ..................... skipped: PublicInbox::Gcf2 missing for t/gcf2.t > > > > > > That means gcf2 isn't getting built, right? > > > > Yeah, assuming all dependencies are there; > > is PERL_INLINE_DIRECTORY set (or ~/.cache/public-inbox/inline-c exists?) > > Ah, yes, when I build as part of the dockerfile image, that dir is absent. > It shouldn't matter for actual usage, though -- so we can ignore this. > > Sorry for a lot of noise about it, just want to make sure I got everything > working. :) > > I'll follow up with my draft instructions on how to get things running with > toolbox. No worries, I think the test can show diagnostic info without being too alarming for optional dependencies: --------8<-------- Subject: [PATCH] test_common: print diagnostic for missing dependencies The "#" prefix should prevent it from being too alarming if a dependency is expected to be missing, but still useful if a dependency is misconfigured. --- lib/PublicInbox/TestCommon.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm index 83dcf650..2e3e9ecc 100644 --- a/lib/PublicInbox/TestCommon.pm +++ b/lib/PublicInbox/TestCommon.pm @@ -144,6 +144,7 @@ sub require_mods { eval "require $mod"; } if ($@) { + diag "require $mod: $@"; push @need, $mod; } elsif ($mod eq 'IO::Socket::SSL' && # old versions of IO::Socket::SSL aren't supported