From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id D74FC1F8C6;
	Thu,  9 Sep 2021 21:23:48 +0000 (UTC)
Date: Thu, 9 Sep 2021 21:23:48 +0000
From: Eric Wong <e@80x24.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] gcf2: die if pkg-config is missing
Message-ID: <20210909212348.GA31420@dcvr>
References: <20210909182350.yzhdw3znylowb3im@meerkat.local>
 <20210909204541.GA11866@dcvr>
 <20210909210138.ssiv5tri65mf4l4o@meerkat.local>
 <20210909211436.GA29028@dcvr>
 <20210909212105.qbrdlu37b6bbz2ij@meerkat.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210909212105.qbrdlu37b6bbz2ij@meerkat.local>
List-Id: <meta.public-inbox.org>

Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> On Thu, Sep 09, 2021 at 09:14:36PM +0000, Eric Wong wrote:
> > Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> > > Yep, that was the culprit. After installing pkg-config, gcf2 builds and tests
> > > pass. I still have this while running "make test":
> > 
> > Good to know.  We'll have to document that when adding libgit2
> > stuff to the already-huge INSTALL file.
> 
> Annoyingly, after I blow away the container to start fresh, I get:
> 
>     t/gcf2.t ..................... skipped: PublicInbox::Gcf2 missing for t/gcf2.t
> 
> That means gcf2 isn't getting built, right?

Yeah, assuming all dependencies are there;
is PERL_INLINE_DIRECTORY set (or ~/.cache/public-inbox/inline-c exists?)