From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 63BA41F8C6 for ; Thu, 9 Sep 2021 21:21:08 +0000 (UTC) Received: by mail-qk1-x72f.google.com with SMTP id a66so3526011qkc.1 for ; Thu, 09 Sep 2021 14:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WwKOFRPyQNByTCljEHUjvF1Duh0IfsGvfgrfBilX4wA=; b=Qmp1WXF12Z4K+HGtNbJLcCb6EQamIM1IZm4gvVgAYPllctqO2IGyqJll3TJEECYoe/ uu4XN7rqs7dW1vGJOvU5I4GKRiiicrNzkC0LbBSBw9uVi8bWbYTCaoszfIpWAbufwaL6 s7E0TzWfStEtd1O95ofG5Yoyj/p++ihjOCz2s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WwKOFRPyQNByTCljEHUjvF1Duh0IfsGvfgrfBilX4wA=; b=OAdVDLatLKxyqxEEm2+Xpcbq6uGEBVHsXgwCs4QFA816SEh30QALgfm7ltH0M3Arah bGVHib1APXCXtbvltVIYLUIzDuDPFa4WUUwGiDb8OKZu8xm3E5rcRPCjvuHfvp9tiaOe Cruv80MS/pSgYowfdxxjp/i+40XJyrHM0X9J8hdUY34JGBUq6METORLOqpbhRYUjUgIk 6oP3q7axwzLoz0qYfWmdVK9rzW5ng/qDxFjseXGEK1GeUlvGvcXdKBVAnUz7sp8coeSs kInzFM8MT+TmvUCFRXgGlMjJ+h/7GMfvjBvdrx/dXD8iGrsl6xZaBjtiVK9/JrOm9G5x ZL1g== X-Gm-Message-State: AOAM530RgayusKGXs1+7zMCQxkasQsnxLb0c7MrOgcYTgOFk0d44z0K3 Dt9RcEDDmYEKbK50P0lbdq+CXQ== X-Google-Smtp-Source: ABdhPJzkUsbPimaOSiDBV7Nby3+CqFBBr1FuwyIaHKo7APYM+Dq1zb9hFusGUgpyz565oLI5ZNyxXA== X-Received: by 2002:a05:620a:1671:: with SMTP id d17mr5088153qko.191.1631222467417; Thu, 09 Sep 2021 14:21:07 -0700 (PDT) Received: from meerkat.local (bras-base-mtrlpq5031w-grc-32-216-209-220-181.dsl.bell.ca. [216.209.220.181]) by smtp.gmail.com with ESMTPSA id d20sm2170717qkl.13.2021.09.09.14.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 14:21:07 -0700 (PDT) Date: Thu, 9 Sep 2021 17:21:05 -0400 From: Konstantin Ryabitsev To: Eric Wong Cc: meta@public-inbox.org Subject: Re: [PATCH] gcf2: die if pkg-config is missing Message-ID: <20210909212105.qbrdlu37b6bbz2ij@meerkat.local> References: <20210909182350.yzhdw3znylowb3im@meerkat.local> <20210909204541.GA11866@dcvr> <20210909210138.ssiv5tri65mf4l4o@meerkat.local> <20210909211436.GA29028@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210909211436.GA29028@dcvr> List-Id: On Thu, Sep 09, 2021 at 09:14:36PM +0000, Eric Wong wrote: > Konstantin Ryabitsev wrote: > > Yep, that was the culprit. After installing pkg-config, gcf2 builds and tests > > pass. I still have this while running "make test": > > Good to know. We'll have to document that when adding libgit2 > stuff to the already-huge INSTALL file. Annoyingly, after I blow away the container to start fresh, I get: t/gcf2.t ..................... skipped: PublicInbox::Gcf2 missing for t/gcf2.t That means gcf2 isn't getting built, right? -K