From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 967B71F8C6; Thu, 9 Sep 2021 21:14:36 +0000 (UTC) Date: Thu, 9 Sep 2021 21:14:36 +0000 From: Eric Wong To: Konstantin Ryabitsev Cc: meta@public-inbox.org Subject: Re: [PATCH] gcf2: die if pkg-config is missing Message-ID: <20210909211436.GA29028@dcvr> References: <20210909182350.yzhdw3znylowb3im@meerkat.local> <20210909204541.GA11866@dcvr> <20210909210138.ssiv5tri65mf4l4o@meerkat.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210909210138.ssiv5tri65mf4l4o@meerkat.local> List-Id: Konstantin Ryabitsev wrote: > Yep, that was the culprit. After installing pkg-config, gcf2 builds and tests > pass. I still have this while running "make test": Good to know. We'll have to document that when adding libgit2 stuff to the already-huge INSTALL file. > t/git.t ...................... 1/? fatal: Needed a single revision > > But I do get "All tests successful" in the end, so I assume that's the > expected condition. Yes, it was making sure errors got propagated properly. It always got lost in the "make -j4 check" parallel output for me :x --------8<--------- Subject: [PATCH] t/git.t: quiet intentional git-rev-parse failure It can get confusing, especially when running non-parallel "make test" Link: https://public-inbox.org/meta/20210909210138.ssiv5tri65mf4l4o@meerkat.local/ --- t/git.t | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/t/git.t b/t/git.t index bc1dea50..844e0111 100644 --- a/t/git.t +++ b/t/git.t @@ -98,8 +98,10 @@ if (1) { $gcf->qx(qw(repack -adq)); ok($gcf->packed_bytes > 0, 'packed size is positive'); - $gcf->qx(qw(rev-parse --verify bogus)); - isnt($?, 0, '$? set on failure'.$?); + my $rdr; + open $rdr->{2}, '+>', '/dev/null' or xbail "open $!"; + $gcf->qx([qw(rev-parse --verify bogus)], undef, $rdr); + isnt($?, 0, '$? set on failure: '.$?); } SKIP: {