From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 57D7B1F8C6 for ; Thu, 9 Sep 2021 21:01:41 +0000 (UTC) Received: by mail-qt1-x830.google.com with SMTP id b14so2783908qtb.0 for ; Thu, 09 Sep 2021 14:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=p2oEsMWRPSaJgGISK/AkfV+rPqAC3LHec6Tr1Dk39fA=; b=OhVDsQ+gWpVxLGhFss5kHtwCecFwTWpIUhOVbsTpwIaFD00Av19nkympZjI3jS89v2 AMiqBr6bY1llDjlD8jGudZFMNCt/srIO+S4TB1bzLRsVTobTYtWuthJ/4xHUEQfAxp9a 7F6ZO4WVvvBQJzZtI0GAMD00HuhndgB4LippE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p2oEsMWRPSaJgGISK/AkfV+rPqAC3LHec6Tr1Dk39fA=; b=fgtGmyXs42m57j2utIOZS5YOZfjIbfPn07JB3koN3p24c1OyiwBlBEdQ9IbsqrQl7p vIAQyynqFETViFHkgWEh6JwwFjXhL+vm9xWp5Hau34uLhbsKaGFTwI84l60Otktl4XXZ qmBdOmvlrtkyBviocpkBeH7U+tM1eDtsX9KwxP6YfwtBKG4oTchFpXmSI5t9CeEYWDdA 8t/AkTgDSFg0Y1nXR1dzkFA70k70r9IfYWj/uEpG49Y0mrOanNVwFEQkdOEJw9ZlySvk AXDed0iuL0dT8TDi1MWwpVV+pazWm+YM8tIYsxEzkMGC+n9+MdmQykapyLDN9jRmJt9u vI6g== X-Gm-Message-State: AOAM533rxakpkUHtKxLME9h+KyMD0ayDGx8cMV3oVmYSTvn6zVcKcohq oO+Lq52Es3X7KKmHKqtjD1jozw== X-Google-Smtp-Source: ABdhPJxulSvgfH/0G8QBRbqUSTYHpi8Wt2ax74Aw7rwZrTP/a0BADM83aFLXCb9lVO49P4VWeGiFYw== X-Received: by 2002:ac8:4892:: with SMTP id i18mr5068357qtq.13.1631221300128; Thu, 09 Sep 2021 14:01:40 -0700 (PDT) Received: from meerkat.local (bras-base-mtrlpq5031w-grc-32-216-209-220-181.dsl.bell.ca. [216.209.220.181]) by smtp.gmail.com with ESMTPSA id j26sm2192669qki.26.2021.09.09.14.01.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 14:01:39 -0700 (PDT) Date: Thu, 9 Sep 2021 17:01:38 -0400 From: Konstantin Ryabitsev To: Eric Wong Cc: meta@public-inbox.org Subject: Re: [PATCH] gcf2: die if pkg-config is missing Message-ID: <20210909210138.ssiv5tri65mf4l4o@meerkat.local> References: <20210909182350.yzhdw3znylowb3im@meerkat.local> <20210909204541.GA11866@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210909204541.GA11866@dcvr> List-Id: On Thu, Sep 09, 2021 at 08:45:41PM +0000, Eric Wong wrote: > Konstantin Ryabitsev wrote: > > Hello: > > > > I can't seem to get a clean "make test" in the Debian container. It's possible > > that I'm missing some of the packages, as the official Debian container image > > is very minimal. > > Not sure, it's taking forever to update one of my VMs... > > > The dockerfile is here: https://gist.github.com/mricon/046ba7c8b03bd92176dbe83e04f2466c > > > > The pertinent section is: > > RUN apt-get -y install git liburi-perl libemail-mime-perl libplack-perl libtimedate-perl \ > > libdbd-sqlite3-perl libsearch-xapian-perl libnet-server-perl \ > > libinline-c-perl libemail-address-xs-perl libparse-recdescent-perl \ > > xapian-tools libencode-perl libdbi-perl liblinux-inotify2-perl \ > > libio-compress-perl curl libmail-imapclient-perl sqlite3 \ > > libgit2-dev make eatmydata > > Oops, pkg-config is needed for libgit2-dev. I thought most > *-dev packages would pull it in... Yep, that was the culprit. After installing pkg-config, gcf2 builds and tests pass. I still have this while running "make test": t/git.t ...................... 1/? fatal: Needed a single revision But I do get "All tests successful" in the end, so I assume that's the expected condition. Thanks, -K